From yarn-issues-return-155158-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Fri Oct 12 05:34:06 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id C672718067A for ; Fri, 12 Oct 2018 05:34:05 +0200 (CEST) Received: (qmail 60547 invoked by uid 500); 12 Oct 2018 03:34:04 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 60532 invoked by uid 99); 12 Oct 2018 03:34:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 12 Oct 2018 03:34:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id DA74F1A2684 for ; Fri, 12 Oct 2018 03:34:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.301 X-Spam-Level: X-Spam-Status: No, score=-110.301 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id oWQysvwjoCoC for ; Fri, 12 Oct 2018 03:34:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 7ECC45F4A9 for ; Fri, 12 Oct 2018 03:34:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 85269E0E3E for ; Fri, 12 Oct 2018 03:34:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 3130D24DBF for ; Fri, 12 Oct 2018 03:34:00 +0000 (UTC) Date: Fri, 12 Oct 2018 03:34:00 +0000 (UTC) From: "Hadoop QA (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-8872) Optimize collections used by Yarn JHS to reduce its memory MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-8872?page=3Dcom.atlassian.= jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16647= 377#comment-16647377 ]=20 Hadoop QA commented on YARN-8872: --------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 14s= {color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0= m 0s{color} | {color:green} The patch does not contain any @author tags. {= color} | | {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m = 0s{color} | {color:red} The patch doesn't appear to include any new or modi= fied tests. Please justify why no new tests are needed for this patch. Also= please list what manual steps were performed to verify this patch. {color}= | || || || || {color:brown} trunk Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m 9s= {color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}= 21m 22s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 2= m 6s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}= 0m 46s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1= m 9s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:gree= n} 13m 18s{color} | {color:green} branch has no errors when building and te= sting our client artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} = 1m 35s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0= m 37s{color} | {color:green} trunk passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 11s= {color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}= 1m 2s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1= m 52s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m = 52s{color} | {color:green} the patch passed {color} | | {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:oran= ge} 0m 41s{color} | {color:orange} hadoop-mapreduce-project/hadoop-mapredu= ce-client: The patch generated 6 new + 179 unchanged - 6 fixed =3D 185 tota= l (was 185) {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0= m 59s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green}= 0m 0s{color} | {color:green} The patch has no whitespace issues. {color}= | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:gree= n} 12m 32s{color} | {color:green} patch has no errors when building and tes= ting our client artifacts. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m 3s= {color} | {color:red} hadoop-mapreduce-project/hadoop-mapreduce-client/hado= op-mapreduce-client-core generated 1 new + 0 unchanged - 0 fixed =3D 1 tota= l (was 0) {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0= m 34s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m 4= 5s{color} | {color:green} hadoop-mapreduce-client-core in the patch passed.= {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m 2= 9s{color} | {color:green} hadoop-mapreduce-client-hs in the patch passed. {= color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green}= 0m 23s{color} | {color:green} The patch does not generate ASF License war= nings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 68m 55s{colo= r} | {color:black} {color} | \\ \\ || Reason || Tests || | FindBugs | module:hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop= -mapreduce-client-core | | | Inconsistent synchronization of org.apache.hadoop.mapreduce.counters.= FileSystemCounterGroup.map; locked 46% of time Unsynchronized access at Fi= leSystemCounterGroup.java:46% of time Unsynchronized access at FileSystemC= ounterGroup.java:[line 281] | \\ \\ || Subsystem || Report/Notes || | Docker | Client=3D17.05.0-ce Server=3D17.05.0-ce Image:yetus/hadoop:4b8c2= b1 | | JIRA Issue | YARN-8872 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/1294357= 9/YARN-8872.01.patch | | Optional Tests | dupname asflicense compile javac javadoc mvninstal= l mvnsite unit shadedclient findbugs checkstyle | | uname | Linux 122758dc17b1 3.13.0-153-generic #203-Ubuntu SMP Thu Jun 14 = 08:52:28 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | trunk / 604c27c | | maven | version: Apache Maven 3.3.9 | | Default Java | 1.8.0_181 | | findbugs | v3.1.0-RC1 | | checkstyle | https://builds.apache.org/job/PreCommit-YARN-Build/22163/art= ifact/out/diff-checkstyle-hadoop-mapreduce-project_hadoop-mapreduce-client.= txt | | findbugs | https://builds.apache.org/job/PreCommit-YARN-Build/22163/artif= act/out/new-findbugs-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoo= p-mapreduce-client-core.html | | Test Results | https://builds.apache.org/job/PreCommit-YARN-Build/22163/= testReport/ | | Max. process+thread count | 306 (vs. ulimit of 10000) | | modules | C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapr= educe-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-m= apreduce-client-hs U: hadoop-mapreduce-project/hadoop-mapreduce-client | | Console output | https://builds.apache.org/job/PreCommit-YARN-Build/22163= /console | | Powered by | Apache Yetus 0.8.0 http://yetus.apache.org | This message was automatically generated. > Optimize collections used by Yarn JHS to reduce its memory > ---------------------------------------------------------- > > Key: YARN-8872 > URL: https://issues.apache.org/jira/browse/YARN-8872 > Project: Hadoop YARN > Issue Type: Improvement > Components: yarn > Reporter: Misha Dmitriev > Assignee: Misha Dmitriev > Priority: Major > Attachments: YARN-8872.01.patch, jhs-bad-collections.png > > > We analyzed, using jxray (www.jxray.com) a heap dump of JHS running with = big heap in a large clusters, handling large MapReduce jobs. The heap is la= rge (over 32GB) and 21.4% of it is wasted due to various suboptimal Java co= llections, mostly maps and lists that are either empty or contain only one = element. In such under-populated collections considerable amount of memory = is still used by just the internal implementation objects. See the attached= excerpt from the jxray report for the details. If certain collections are = almost always empty, they should be initialized lazily. If others almost al= ways have just 1 or 2 elements, they should be initialized with the appropr= iate initial capacity of 1 or 2 (the default capacity is 16 for HashMap and= 10 for ArrayList). > Based on the attached report, we should do the following: > # {{FileSystemCounterGroup.map}} - initialize lazily > # {{CompletedTask.attempts}} - initialize with=C2=A0 capacity 2, given m= ost tasks only have one or two attempts > # {{JobHistoryParser$TaskInfo.attemptsMap}} - initialize with capacity > # {{CompletedTaskAttempt.diagnostics}} - initialize with capacity 1 sinc= e it contains one diagnostic message most of the time > # {{CompletedTask.reportDiagnostics}} - switch to ArrayList (no reason t= o use the more wasteful LinkedList here) and initialize with capacity 1. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: yarn-issues-help@hadoop.apache.org