From yarn-issues-return-154763-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Tue Oct 9 00:57:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id B5D20180652 for ; Tue, 9 Oct 2018 00:57:03 +0200 (CEST) Received: (qmail 79929 invoked by uid 500); 8 Oct 2018 22:57:02 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 79913 invoked by uid 99); 8 Oct 2018 22:57:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 08 Oct 2018 22:57:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 3FA6AC6FB8 for ; Mon, 8 Oct 2018 22:57:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id l4CN2bmsrHw5 for ; Mon, 8 Oct 2018 22:57:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 640E85F41C for ; Mon, 8 Oct 2018 22:57:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id A2C29E1328 for ; Mon, 8 Oct 2018 22:57:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 1E25E247FD for ; Mon, 8 Oct 2018 22:57:00 +0000 (UTC) Date: Mon, 8 Oct 2018 22:57:00 +0000 (UTC) From: =?utf-8?Q?=C3=8D=C3=B1igo_Goiri_=28JIRA=29?= To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-8827) Plumb per app, per user and per queue resource utilization from the NM to RM MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-8827?page=3Dcom.atlassian.= jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16642= 579#comment-16642579 ]=20 =C3=8D=C3=B1igo Goiri commented on YARN-8827: ----------------------------------- bq. Hmmm, not sure what you meant by this. The test case uses the MockNM an= d MockRM classes which I think we use throughout most CapacityScheduler tes= ts. Not sure how we can move it inside the class. I was talking about making nm1, nm2, nm3, nm4 part of the class as fields. Then, we could have a method to trigger all heartbeats. Probably also call the drainEvents and wait for event thread, etc. bq. Ive added a javadoc before the testcase and some demarcation within the= testcase - to mark begining and end of each step - hope that clears things= ? Looks good. I would probably quote the relevant numbers that are being used= here. bq. If you don't mind, id like to keep it as 'e' The point was to reduce t= he typing and length of the line. Also I don't plan to re-use it ouside the= this testcase, so lets keep it as private. If I do reuse it, I will create= a TestUtil class and put everything there - and probably rename it. OK. For the sleep removal, this looks better. Why do we have to run the heartbeats three times? > Plumb per app, per user and per queue resource utilization from the NM to= RM > -------------------------------------------------------------------------= --- > > Key: YARN-8827 > URL: https://issues.apache.org/jira/browse/YARN-8827 > Project: Hadoop YARN > Issue Type: Sub-task > Reporter: Arun Suresh > Assignee: Arun Suresh > Priority: Major > Attachments: YARN-8827-YARN-1011.01.patch, YARN-8827-YARN-1011.02= .patch > > > Opportunistic Containers for OverAllocation need to be allocated to pendi= ng applications in some fair manner. Rather than evaluating queue and user = resource usage (allocated resource usage) and comparing against queue and u= ser limits to decide the allocation, it might make more sense to use a sna= pshot of actual resource utilization of the queue and user. > To facilitate this, this JIRA proposes to aggregate per user, per app (an= d maybe per queue) resource utilization in addition to aggregated Container= and Node Utilization and send it along with the NM heartbeat. It should be= fairly inexpensive to aggregate - since it can be performed in the same lo= op of the {{ContainersMonitorImpl}}'s Monitoring thread. > A snapshot aggregate can be made every couple of seconds in the RM. This = instantaneous resource utilization should be used to decide if Opportunisti= c containers can be allocated to an App, Queue or User. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: yarn-issues-help@hadoop.apache.org