From yarn-issues-return-154809-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Tue Oct 9 14:35:07 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id E5BE9180668 for ; Tue, 9 Oct 2018 14:35:06 +0200 (CEST) Received: (qmail 57178 invoked by uid 500); 9 Oct 2018 12:35:06 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 57165 invoked by uid 99); 9 Oct 2018 12:35:06 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 09 Oct 2018 12:35:05 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 954D7C6D84 for ; Tue, 9 Oct 2018 12:35:05 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id K9HQbLHf_ODU for ; Tue, 9 Oct 2018 12:35:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 449AC5F357 for ; Tue, 9 Oct 2018 12:35:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 8610BE0DAA for ; Tue, 9 Oct 2018 12:35:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 520FA24805 for ; Tue, 9 Oct 2018 12:35:00 +0000 (UTC) Date: Tue, 9 Oct 2018 12:35:00 +0000 (UTC) From: "Hadoop QA (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-8468) Enable the use of queue based maximum container allocation limit and implement it in FairScheduler MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-8468?page=3Dcom.atlassian.= jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16643= 272#comment-16643272 ]=20 Hadoop QA commented on YARN-8468: --------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 28m 55s= {color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0= m 0s{color} | {color:green} The patch does not contain any @author tags. {= color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green}= 0m 0s{color} | {color:green} The patch appears to include 15 new or modi= fied test files. {color} | || || || || {color:brown} branch-3.1 Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 27s= {color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}= 24m 25s{color} | {color:green} branch-3.1 passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 12= m 23s{color} | {color:green} branch-3.1 passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}= 1m 28s{color} | {color:green} branch-3.1 passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1= m 17s{color} | {color:green} branch-3.1 passed {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:gree= n} 13m 7s{color} | {color:green} branch has no errors when building and te= sting our client artifacts. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m = 0s{color} | {color:blue} Skipped patched modules with no Java source: hadoo= p-yarn-project/hadoop-yarn/hadoop-yarn-site {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} = 1m 16s{color} | {color:green} branch-3.1 passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0= m 52s{color} | {color:green} branch-3.1 passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 13s= {color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}= 0m 54s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 9= m 55s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 9m = 55s{color} | {color:green} the patch passed {color} | | {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:oran= ge} 1m 24s{color} | {color:orange} hadoop-yarn-project/hadoop-yarn: The pa= tch generated 10 new + 858 unchanged - 19 fixed =3D 868 total (was 877) {co= lor} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1= m 9s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green}= 0m 0s{color} | {color:green} The patch has no whitespace issues. {color}= | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:gree= n} 10m 46s{color} | {color:green} patch has no errors when building and tes= ting our client artifacts. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m = 0s{color} | {color:blue} Skipped patched modules with no Java source: hadoo= p-yarn-project/hadoop-yarn/hadoop-yarn-site {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} = 1m 17s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0= m 44s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} unit {color} | {color:red} 84m 34s{col= or} | {color:red} hadoop-yarn-server-resourcemanager in the patch failed. {= color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 1= 7s{color} | {color:green} hadoop-yarn-site in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green}= 0m 47s{color} | {color:green} The patch does not generate ASF License war= nings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}195m 52s{colo= r} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=3D17.05.0-ce Server=3D17.05.0-ce Image:yetus/hadoop:a607c= 02 | | JIRA Issue | YARN-8468 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/1294298= 5/YARN-8468-branch-3.1.019.patch | | Optional Tests | dupname asflicense compile javac javadoc mvninstal= l mvnsite unit shadedclient findbugs checkstyle | | uname | Linux a19876d0a399 4.4.0-133-generic #159-Ubuntu SMP Fri Aug 10 0= 7:31:43 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | branch-3.1 / 665036c | | maven | version: Apache Maven 3.3.9 | | Default Java | 1.8.0_181 | | findbugs | v3.1.0-RC1 | | checkstyle | https://builds.apache.org/job/PreCommit-YARN-Build/22108/art= ifact/out/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt | | unit | https://builds.apache.org/job/PreCommit-YARN-Build/22108/artifact/= out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-ya= rn-server-resourcemanager.txt | | Test Results | https://builds.apache.org/job/PreCommit-YARN-Build/22108/= testReport/ | | Max. process+thread count | 820 (vs. ulimit of 10000) | | modules | C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-ya= rn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site = U: hadoop-yarn-project/hadoop-yarn | | Console output | https://builds.apache.org/job/PreCommit-YARN-Build/22108= /console | | Powered by | Apache Yetus 0.8.0 http://yetus.apache.org | This message was automatically generated. > Enable the use of queue based maximum container allocation limit and impl= ement it in FairScheduler > -------------------------------------------------------------------------= ------------------------- > > Key: YARN-8468 > URL: https://issues.apache.org/jira/browse/YARN-8468 > Project: Hadoop YARN > Issue Type: Improvement > Components: fairscheduler, scheduler > Affects Versions: 3.1.0 > Reporter: Antal B=C3=A1lint Steinbach > Assignee: Antal B=C3=A1lint Steinbach > Priority: Critical > Fix For: 3.2.0 > > Attachments: YARN-8468-branch-3.1.018.patch, YARN-8468-branch-3.1= .019.patch, YARN-8468.000.patch, YARN-8468.001.patch, YARN-8468.002.patch, = YARN-8468.003.patch, YARN-8468.004.patch, YARN-8468.005.patch, YARN-8468.00= 6.patch, YARN-8468.007.patch, YARN-8468.008.patch, YARN-8468.009.patch, YAR= N-8468.010.patch, YARN-8468.011.patch, YARN-8468.012.patch, YARN-8468.013.p= atch, YARN-8468.014.patch, YARN-8468.015.patch, YARN-8468.016.patch, YARN-8= 468.017.patch, YARN-8468.018.patch > > > When using any scheduler, you can use "yarn.scheduler.maximum-allocation-= mb" to limit the overall size of a container. This applies globally to all = containers and cannot be limited by queue or and is not scheduler dependent= . > The goal of this ticket is to allow this value to be set on a per queue b= asis. > The use case: User has two pools, one for ad hoc jobs and one for enterpr= ise apps. User wants to limit ad hoc jobs to small containers but allow ent= erprise apps to request as many resources as needed. Setting yarn.scheduler= .maximum-allocation-mb sets a default value for maximum container size for = all queues and setting maximum resources per queue with =E2=80=9CmaxContain= erResources=E2=80=9D queue config value. > Suggested solution: > All the infrastructure is already in the code. We need to do the followin= g: > * add the setting to the queue properties for all queue types (parent an= d leaf), this will cover dynamically created queues. > * if we set it on the root we override the scheduler setting and we shou= ld not allow that. > * make sure that queue resource cap can not be larger than scheduler max= resource cap in the config. > * implement=C2=A0getMaximumResourceCapability(String queueName)=C2=A0in = the FairScheduler > * implement=C2=A0getMaximumResourceCapability(String queueName)=C2=A0in = both FSParentQueue and FSLeafQueue as follows > * expose the setting in the queue information in the RM web UI. > * expose the setting in the metrics etc for the queue. > * Enforce the use of queue based maximum allocation limit if it is avail= able, if not use the general scheduler level setting > ** Use it during validation and normalization of requests in scheduler.a= llocate, app submit and resource request -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: yarn-issues-help@hadoop.apache.org