From yarn-issues-return-155777-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Fri Oct 19 15:41:03 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 3C2BC180652 for ; Fri, 19 Oct 2018 15:41:03 +0200 (CEST) Received: (qmail 12890 invoked by uid 500); 19 Oct 2018 13:41:02 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 12879 invoked by uid 99); 19 Oct 2018 13:41:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 19 Oct 2018 13:41:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id CF7431A25CD for ; Fri, 19 Oct 2018 13:41:01 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.301 X-Spam-Level: X-Spam-Status: No, score=-110.301 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id kYyoS5T6IgSY for ; Fri, 19 Oct 2018 13:41:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id D20EB5F24A for ; Fri, 19 Oct 2018 13:41:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 76087E0E87 for ; Fri, 19 Oct 2018 13:41:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 135F72528E for ; Fri, 19 Oct 2018 13:41:00 +0000 (UTC) Date: Fri, 19 Oct 2018 13:41:00 +0000 (UTC) From: "Szilard Nemeth (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-8059) Resource type is ignored when FS decide to preempt MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-8059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16656820#comment-16656820 ] Szilard Nemeth commented on YARN-8059: -------------------------------------- Hi [~wilfreds]! Thanks for your comments! 1. If you meant we need to zero the values for memory / cores within the same loop, I did the fix for that in {{subtractFromNonNegative}} 2. Fixed the name of the variable, it was indeed confusing. 3. Fixed the indents and line breaks. Tests: 1. You are right, I debugged a bit and also had the memory fully utilizied. It was caused by the {{RM_SCHEDULER_INCREMENT_ALLOCATION_MB}} scheduler config, I decreased its value to 100 so I could request 400mb * so that it haven't reached the cluster's capacity. This way, the test still passes but only because the custom resource utilization is reached the cluster capacity of that resource. 2. I don't really get this. Do you mean to use resource requests with smaller amounts of memory / vcores to have the custom resource as the dominant? What is the problem with the allocation request build? Uploaded a new patch that fixes most of your comments. Thanks! > Resource type is ignored when FS decide to preempt > -------------------------------------------------- > > Key: YARN-8059 > URL: https://issues.apache.org/jira/browse/YARN-8059 > Project: Hadoop YARN > Issue Type: Bug > Components: fairscheduler > Affects Versions: 3.0.0 > Reporter: Yufei Gu > Assignee: Szilard Nemeth > Priority: Major > Attachments: YARN-8059.001.patch, YARN-8059.002.patch, YARN-8059.003.patch, YARN-8059.004.patch > > > Method Fairscheduler#shouldAttemptPreemption doesn't consider resources other than vcore and memory. We may need to rethink it in the resource type scenario. cc [~miklos.szegedi@cloudera.com], [~wilfreds] and [~snemeth]. > {code} > if (context.isPreemptionEnabled()) { > return (context.getPreemptionUtilizationThreshold() < Math.max( > (float) rootMetrics.getAllocatedMB() / > getClusterResource().getMemorySize(), > (float) rootMetrics.getAllocatedVirtualCores() / > getClusterResource().getVirtualCores())); > } > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: yarn-issues-help@hadoop.apache.org