From yarn-issues-return-156040-apmail-hadoop-yarn-issues-archive=hadoop.apache.org@hadoop.apache.org Mon Oct 22 23:55:03 2018 Return-Path: X-Original-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 90AC81810C for ; Mon, 22 Oct 2018 23:55:03 +0000 (UTC) Received: (qmail 93733 invoked by uid 500); 22 Oct 2018 23:55:03 -0000 Delivered-To: apmail-hadoop-yarn-issues-archive@hadoop.apache.org Received: (qmail 93679 invoked by uid 500); 22 Oct 2018 23:55:03 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 93668 invoked by uid 99); 22 Oct 2018 23:55:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 22 Oct 2018 23:55:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id D39AF1822D4 for ; Mon, 22 Oct 2018 23:55:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 1VJ0TNetmD1Z for ; Mon, 22 Oct 2018 23:55:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id EBB675F36F for ; Mon, 22 Oct 2018 23:55:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 0BC62E2632 for ; Mon, 22 Oct 2018 23:55:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 6F993252AA for ; Mon, 22 Oct 2018 23:55:00 +0000 (UTC) Date: Mon, 22 Oct 2018 23:55:00 +0000 (UTC) From: =?utf-8?Q?=C3=8D=C3=B1igo_Goiri_=28JIRA=29?= To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-8911) ContainerScheduler incorrectly uses percentage number as the cpu resource utlization MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-8911?page=3Dcom.atlassian.= jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16659= 851#comment-16659851 ]=20 =C3=8D=C3=B1igo Goiri commented on YARN-8911: ----------------------------------- I don't think we have very good coverage of this code. Is there any test that would track this from the container to the RM? > ContainerScheduler incorrectly uses percentage number as the cpu resource= utlization > -------------------------------------------------------------------------= ----------- > > Key: YARN-8911 > URL: https://issues.apache.org/jira/browse/YARN-8911 > Project: Hadoop YARN > Issue Type: Bug > Components: nodemanager > Reporter: Haibo Chen > Assignee: Haibo Chen > Priority: Major > Attachments: YARN-8911.00.patch, YARN-8911.01.patch > > > *UPDATE*:=C2=A0 *per discussion below, the cpu resource utlization (Resou= rceUtilzation.cpu) is incorrectly documented as a percentage number in [0, = 1.0] in the java doc. It is however, used as the number of vcores used thro= ughout the system.=C2=A0 YARN-4597 is a victim of the=C2=A0 misleading java= doc.* > =C2=A0 > =C2=A0 > ResourceUtilization represents the cpu utilization with a float number in= [0, 1.0], i.e. the percentage of cpu usage across the node.=C2=A0 However,= when Containers Monitor tracks the total aggregate resource utilization of= all containers, it adds up the total number of vcores used by all running = containers. > =C2=A0 > (If you have 6 containers running, each consuming 1 vcore, you'd see the = aggregated cpu container utilization being 6.0, but it's supposed to be alw= ays between 0 and 1.0)=C2=A0=C2=A0 See [the code|https://github.com/apache/= hadoop/blob/beb850d8f7f1fefa7a6d9502df2b4a4eea372523/hadoop-yarn-project/ha= doop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/o= rg/apache/hadoop/yarn/server/nodemanager/containermanager/monitor/Container= sMonitorImpl.java#L672] -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: yarn-issues-help@hadoop.apache.org