hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Íñigo Goiri (JIRA) <j...@apache.org>
Subject [jira] [Commented] (YARN-8928) TestRMAdminService is failing
Date Mon, 22 Oct 2018 21:28:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-8928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16659696#comment-16659696
] 

Íñigo Goiri commented on YARN-8928:
-----------------------------------

For the comment, I meant consolidating everything into the new function, something like:
{code}
  /**
   * ACL Strings will be generated in alphabetical order. Since test depends on this
   * arbitrary name of the user running the tests, there needs to be some work to
   * ensure the proper order (alphabetical). This utility puts a user name in the correct
   * position relative to other ACL information.
   */
  private String buildAclString(String userName, String other) {
    SortedSet<String> ret = new TreeSet<>();
    ret.add(userName);
    ret.add(other);
    return StringUtils.join(ret, ",");
  }
{code}
I think using an ordered set is more readable than using the comparator.

No changes to AccessControlList, just to this test.

> TestRMAdminService is failing
> -----------------------------
>
>                 Key: YARN-8928
>                 URL: https://issues.apache.org/jira/browse/YARN-8928
>             Project: Hadoop YARN
>          Issue Type: Bug
>    Affects Versions: 3.3.0
>            Reporter: Jason Lowe
>            Assignee: BELUGA BEHR
>            Priority: Major
>         Attachments: YARN-8928.1.patch, YARN-8928.2.patch, YARN-8928.3.patch
>
>
> After HADOOP-15836 TestRMAdminService has started failing consistently.  Sample stacktraces
to follow.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message