hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Íñigo Goiri (JIRA) <j...@apache.org>
Subject [jira] [Commented] (YARN-8900) [Router] Federation: routing getContainers REST invocations transparently to multiple RMs
Date Wed, 17 Oct 2018 22:44:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-8900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16654318#comment-16654318

Íñigo Goiri commented on YARN-8900:

Thanks [~giovanni.fumarola] for the patch.
A few comments:
* Can you fix the checstyle.
* Can we use Time.now instead of currentTimeMillis?
* Given that we access the response, I don't think we need to check if it's not null.
* No need to specify the type in the new of executor completion service in line 1071.
* Remove empty line 1094 in the interceptor.
* Do you need to close the completion service?
* For the exception management, should we actually throw the exceptions instead of logging
and returning empty?

> [Router] Federation: routing getContainers REST invocations transparently to multiple
> -----------------------------------------------------------------------------------------
>                 Key: YARN-8900
>                 URL: https://issues.apache.org/jira/browse/YARN-8900
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: federation, router
>            Reporter: Giovanni Matteo Fumarola
>            Assignee: Giovanni Matteo Fumarola
>            Priority: Major
>         Attachments: YARN-8900.v1.patch
> This JIRA tracks the design/implementation of the layer for routing RMWebServicesProtocol
requests to the appropriate RM(s) in a federated YARN cluster.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org

View raw message