hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Haibo Chen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-8448) AM HTTPS Support
Date Fri, 12 Oct 2018 18:43:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16648293#comment-16648293
] 

Haibo Chen commented on YARN-8448:
----------------------------------

A few minor comments/questions about the c code changes.

1) In container-executor.c#get_container_keystore_file(), do you think if is more specific
to say 'AM container keystore'? Similar question for get_container_truststore_file().

2) in  create_script_paths(), the error code when checking get_container_launcher_file()
and such should kept as OUT_OF_MEMORY given they are just string concatenation.

3) Looks like we follow c99 standard, so freeing a NULL pointer is not a problem, so we can
remove the if(https=1) check when freeing the related pointers.

4) Let's rename COULD_NOT_CREATE_KEYSTORE_FILE  to COULD_NOT_CREATE_KEYSTORE_COPY and COULD_NOT_CREATE_TRUSTSTORE_FILE 
to COULD_NOT_CREATE_TRUSTSTORE_COPY, given the c code makes a copy.

5) In  test_launch_container(), "logpath" => "container_log_path", " logpathapp" =>
"app_log_path"

 

> AM HTTPS Support
> ----------------
>
>                 Key: YARN-8448
>                 URL: https://issues.apache.org/jira/browse/YARN-8448
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Robert Kanter
>            Assignee: Robert Kanter
>            Priority: Major
>         Attachments: YARN-8448.001.patch, YARN-8448.002.patch, YARN-8448.003.patch, YARN-8448.004.patch,
YARN-8448.005.patch, YARN-8448.006.patch, YARN-8448.007.patch, YARN-8448.008.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message