hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eric Yang (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (YARN-7644) NM gets backed up deleting docker containers
Date Thu, 04 Oct 2018 21:07:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-7644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16638819#comment-16638819
] 

Eric Yang edited comment on YARN-7644 at 10/4/18 9:06 PM:
----------------------------------------------------------

[~csingh] ContainerCleanup is a runnable, and it is a utility class to remove container. 
It would be good to keep this helper class generic and can be reused in deletion task in my
opinion.   Launcher package is all dealing with similar kind of events like launch, relaunch,
or pause launch.  Deletion task has a package prefix of it's own.  Package names appear more
organized, if ContainerCleanup is in deletion.task package, even if the utility class is called
by launch event failure or completion.  That is just my opinion.  I will let others provide
feedback.


was (Author: eyang):
[~csingh] ContainerCleanup a a runnable, and it is a utility class to remove container.  It
would be good to keep this helper class general and can be reused in deletion task in my opinion.
  Launcher package is all dealing with similar kind of events like launch, relaunch, or pause
launch.  Deletion task has a package prefix of it's own.  Package names appear more organized,
if ContainerCleanup is in deletion.task package, even if the utility class is called by launch
event failure or completion.  That is just my opinion.  I will let others provide feedback.

> NM gets backed up deleting docker containers
> --------------------------------------------
>
>                 Key: YARN-7644
>                 URL: https://issues.apache.org/jira/browse/YARN-7644
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: nodemanager
>            Reporter: Eric Badger
>            Assignee: Chandni Singh
>            Priority: Major
>              Labels: Docker
>         Attachments: YARN-7644.001.patch, YARN-7644.002.patch
>
>
> We are sending a {{docker stop}} to the docker container with a timeout of 10 seconds
when we shut down a container. If the container does not stop after 10 seconds then we force
kill it. However, the {{docker stop}} command is a blocking call. So in cases where lots of
containers don't go down with the initial SIGTERM, we have to wait 10+ seconds for the {{docker
stop}} to return. This ties up the ContainerLaunch handler and so these kill events back up.
It also appears to be backing up new container launches as well. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message