hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Lowe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-7018) Interface for adding extra behavior to node heartbeats
Date Wed, 10 Oct 2018 13:38:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-7018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16644967#comment-16644967
] 

Jason Lowe commented on YARN-7018:
----------------------------------

Thanks for updating the patch!  Interface looks good for now.

This JIRA should define the initial interface to the plugin and provide a default implementation
of the plugin that does nothing (i.e.: the null plugin).  NodeHeartbeatPluginImpl and BaseNodeHeartBeatPluginImpl
should not be part of this, IMHO.

Loading the plugin should not be in a base class that implements the plugin -- that belongs
in he AbstractYarnScheduler code that is responsible for loading and initializing the plugin.
 And once that's removed from BaseNodeHeartBeatPluginImpl I don't see a need for that class.

bq. Where shall we keep the plugin? RMActiveService? or Scheduler like Wangda Tan suggested
earlier? 

We can put it in the AbstractYarnScheduler which the latest patch essentially is doing.  The
reinitialize method is loading the plugin and setting it up in the RMContext.

> Interface for adding extra behavior to node heartbeats
> ------------------------------------------------------
>
>                 Key: YARN-7018
>                 URL: https://issues.apache.org/jira/browse/YARN-7018
>             Project: Hadoop YARN
>          Issue Type: New Feature
>          Components: resourcemanager
>            Reporter: Jason Lowe
>            Assignee: Jason Lowe
>            Priority: Major
>         Attachments: YARN-7018.POC.001.patch, YARN-7018.POC.002.patch, YARN-7018.POC.003.patch
>
>
> This JIRA tracks an interface for plugging in new behavior to node heartbeat processing.
 Adding a formal interface for additional node heartbeat processing would allow admins to
configure new functionality that is scheduler-independent without needing to replace the entire
scheduler.  For example, both YARN-5202 and YARN-5215 had approaches where node heartbeat
processing was extended to implement new functionality that was essentially scheduler-independent
and could be implemented as a plugin with this interface.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message