From yarn-issues-return-151201-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Mon Aug 13 18:17:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id DE421180629 for ; Mon, 13 Aug 2018 18:17:03 +0200 (CEST) Received: (qmail 7079 invoked by uid 500); 13 Aug 2018 16:17:03 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 7063 invoked by uid 99); 13 Aug 2018 16:17:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 13 Aug 2018 16:17:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 9C1B2C2E9A for ; Mon, 13 Aug 2018 16:17:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id KSG0ZRiaQgfP for ; Mon, 13 Aug 2018 16:17:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 643125F433 for ; Mon, 13 Aug 2018 16:17:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id A7FFAE111B for ; Mon, 13 Aug 2018 16:17:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 269F323FA0 for ; Mon, 13 Aug 2018 16:17:00 +0000 (UTC) Date: Mon, 13 Aug 2018 16:17:00 +0000 (UTC) From: "Jim Brennan (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-8640) Restore previous state in container-executor if write_exit_code_file_as_nm fails MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-8640?page=3Dcom.atlassian.= jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16578= 547#comment-16578547 ]=20 Jim Brennan commented on YARN-8640: ----------------------------------- Tested by running test-container-executor and cetest - both pass with no er= rors.=C2=A0 Also ran sleep and pi jobs on a single node cluster with and wi= thout docker, and also with NM restart during the jobs. [~jlowe] please review. =C2=A0 > Restore previous state in container-executor if write_exit_code_file_as_n= m fails > -------------------------------------------------------------------------= ------- > > Key: YARN-8640 > URL: https://issues.apache.org/jira/browse/YARN-8640 > Project: Hadoop YARN > Issue Type: Bug > Reporter: Jim Brennan > Assignee: Jim Brennan > Priority: Major > Attachments: YARN-8640.001.patch > > > The container-executor function {{write_exit_code_file_as_nm}}=C2=A0had a= number of failure conditions where it just returns -1 without restoring pr= evious state. > This is not a problem in any of the places where it is currently called, = but it could be a problem if future code changes call it before code that d= epends on the previous state. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: yarn-issues-help@hadoop.apache.org