From yarn-issues-return-151928-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Thu Aug 23 22:14:06 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id E8E3818061A for ; Thu, 23 Aug 2018 22:14:05 +0200 (CEST) Received: (qmail 31854 invoked by uid 500); 23 Aug 2018 20:14:05 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 31843 invoked by uid 99); 23 Aug 2018 20:14:05 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 23 Aug 2018 20:14:05 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 9F646C06F9 for ; Thu, 23 Aug 2018 20:14:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.301 X-Spam-Level: X-Spam-Status: No, score=-110.301 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id RCYyBOx6posF for ; Thu, 23 Aug 2018 20:14:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 0425D5F2F2 for ; Thu, 23 Aug 2018 20:14:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 0D79CE13DA for ; Thu, 23 Aug 2018 20:14:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 6EC4F246AF for ; Thu, 23 Aug 2018 20:14:00 +0000 (UTC) Date: Thu, 23 Aug 2018 20:14:00 +0000 (UTC) From: "genericqa (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-8638) Allow linux container runtimes to be pluggable MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-8638?page=3Dcom.atlassian.= jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16590= 762#comment-16590762 ]=20 genericqa commented on YARN-8638: --------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 29s= {color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0= m 0s{color} | {color:green} The patch does not contain any @author tags. {= color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green}= 0m 0s{color} | {color:green} The patch appears to include 2 new or modif= ied test files. {color} | || || || || {color:brown} trunk Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m 16s= {color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}= 19m 27s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 9= m 7s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}= 1m 30s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1= m 31s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:gree= n} 14m 43s{color} | {color:green} branch has no errors when building and te= sting our client artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} = 2m 30s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1= m 5s{color} | {color:green} trunk passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 14s= {color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}= 1m 18s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 8= m 3s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 8m = 3s{color} | {color:green} the patch passed {color} | | {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:oran= ge} 1m 26s{color} | {color:orange} hadoop-yarn-project/hadoop-yarn: The pa= tch generated 4 new + 223 unchanged - 0 fixed =3D 227 total (was 223) {colo= r} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1= m 25s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green}= 0m 0s{color} | {color:green} The patch has no whitespace issues. {color}= | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:gree= n} 12m 22s{color} | {color:green} patch has no errors when building and tes= ting our client artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} = 3m 11s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m 39s{= color} | {color:red} hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_had= oop-yarn-server-nodemanager generated 1 new + 9 unchanged - 0 fixed =3D 10 = total (was 9) {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 5= 7s{color} | {color:green} hadoop-yarn-api in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 20m = 6s{color} | {color:green} hadoop-yarn-server-nodemanager in the patch passe= d. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green}= 0m 57s{color} | {color:green} The patch does not generate ASF License war= nings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}102m 24s{colo= r} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=3D17.05.0-ce Server=3D17.05.0-ce Image:yetus/hadoop:ba1ab= 08 | | JIRA Issue | YARN-8638 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/1293686= 4/YARN-8638.003.patch | | Optional Tests | dupname asflicense compile javac javadoc mvninstal= l mvnsite unit shadedclient findbugs checkstyle | | uname | Linux 8dc506e639ea 3.13.0-153-generic #203-Ubuntu SMP Thu Jun 14 = 08:52:28 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | trunk / 585ebd8 | | maven | version: Apache Maven 3.3.9 | | Default Java | 1.8.0_181 | | findbugs | v3.1.0-RC1 | | checkstyle | https://builds.apache.org/job/PreCommit-YARN-Build/21667/art= ifact/out/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt | | javadoc | https://builds.apache.org/job/PreCommit-YARN-Build/21667/artifa= ct/out/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-ser= ver_hadoop-yarn-server-nodemanager.txt | | Test Results | https://builds.apache.org/job/PreCommit-YARN-Build/21667/= testReport/ | | Max. process+thread count | 338 (vs. ulimit of 10000) | | modules | C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-= project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: ha= doop-yarn-project/hadoop-yarn | | Console output | https://builds.apache.org/job/PreCommit-YARN-Build/21667= /console | | Powered by | Apache Yetus 0.8.0-SNAPSHOT http://yetus.apache.org | This message was automatically generated. > Allow linux container runtimes to be pluggable > ---------------------------------------------- > > Key: YARN-8638 > URL: https://issues.apache.org/jira/browse/YARN-8638 > Project: Hadoop YARN > Issue Type: Improvement > Components: nodemanager > Affects Versions: 3.2.0 > Reporter: Craig Condit > Assignee: Craig Condit > Priority: Minor > Attachments: YARN-8638.001.patch, YARN-8638.002.patch, YARN-8638.= 003.patch > > > YARN currently supports three different Linux container runtimes (default= , docker, and javasandbox). However, it would be relatively straightforward= to support arbitrary runtime implementations. This would enable easier exp= erimentation with new and emerging runtime technologies (runc, containerd, = etc.) without requiring a rebuild and redeployment of Hadoop.=C2=A0 > This could be accomplished via a simple configuration change: > {code:xml} > > yarn.nodemanager.runtime.linux.allowed-runtimes > default,docker,experimental > > =20 > > yarn.nodemanager.runtime.linux.experimental.class > com.somecompany.yarn.runtime.ExperimentalLinuxContainerRuntime > {code} > =C2=A0 > In this example, {{yarn.nodemanager.runtime.linux.allowed-runtimes}} woul= d now allow arbitrary values. Additionally, {{yarn.nodemanager.runtime.linu= x.\{RUNTIME_KEY}.class}} would indicate the {{LinuxContainerRuntime}} imple= mentation to instantiate. A no-argument constructor should be sufficient, a= s {{LinuxContainerRuntime}} already provides an {{initialize()}} method. > {{DockerLinuxContainerRuntime.isDockerContainerRequested(Map env)}} and {{JavaSandboxLinuxContainerRuntime.isSandboxContainerRequest= ed()}} could be generalized to {{isRuntimeRequested(Map env= )}} and added to the=C2=A0{{LinuxContainerRuntime}}=C2=A0interface. This wo= uld allow {{DelegatingLinuxContainerRuntime}} to select an appropriate runt= ime based on whether that runtime claimed ownership of the current containe= r execution. > For backwards compatibility, the existing values (default,docker,javasand= box) would continue to be supported as-is. Under the current logic, the eva= luation order is javasandbox, docker, default (with default being chosen if= no other candidates are available). Under the new evaluation logic, plugga= ble runtimes would be evaluated after docker and before default, in the ord= er in which they are defined in the allowed-runtimes list. This will change= no behavior on current clusters (as there would be no pluggable runtimes d= efined), and preserves behavior with respect to ordering of existing runtim= es. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: yarn-issues-help@hadoop.apache.org