From yarn-issues-return-150410-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Wed Aug 1 18:26:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 41E9C180634 for ; Wed, 1 Aug 2018 18:26:05 +0200 (CEST) Received: (qmail 65829 invoked by uid 500); 1 Aug 2018 16:26:04 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 65817 invoked by uid 99); 1 Aug 2018 16:26:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Aug 2018 16:26:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id D596B1A1DCE for ; Wed, 1 Aug 2018 16:26:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id ehZdrcG80h7u for ; Wed, 1 Aug 2018 16:26:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 7D8D85F4AA for ; Wed, 1 Aug 2018 16:26:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 20FB4E2638 for ; Wed, 1 Aug 2018 16:26:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 44DC327768 for ; Wed, 1 Aug 2018 16:26:00 +0000 (UTC) Date: Wed, 1 Aug 2018 16:26:00 +0000 (UTC) From: "Haibo Chen (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-7948) Enable refreshing maximum allocation for multiple resource types MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-7948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16565579#comment-16565579 ] Haibo Chen commented on YARN-7948: ---------------------------------- There are a couple of newly added import statements in TestFairScheduler. Because there is no code change, those import statements are unused and therefore can be removed. {quote}Default resources (cpu, memory) are already covered in my testcase in patch002 so I haven't modified this part. {quote} Indeed. My apologies for missing that. While not a strict requirement, given that the vast majority of the code base uses 4 spaces as line continuation, it'd be nice to keep the style consistent. Otherwise, the patch looks fine to me. > Enable refreshing maximum allocation for multiple resource types > ---------------------------------------------------------------- > > Key: YARN-7948 > URL: https://issues.apache.org/jira/browse/YARN-7948 > Project: Hadoop YARN > Issue Type: Improvement > Components: fairscheduler > Affects Versions: 3.0.0 > Reporter: Yufei Gu > Assignee: Szilard Nemeth > Priority: Major > Attachments: YARN-7948.001.patch, YARN-7948.002.patch, YARN-7948.003.patch > > > YARN-7738 did the same thing for CS. We need a fix for FS. We could fix it by moving the refresh code from class CS to class AbstractYARNScheduler. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: yarn-issues-help@hadoop.apache.org