From yarn-issues-return-151934-apmail-hadoop-yarn-issues-archive=hadoop.apache.org@hadoop.apache.org Thu Aug 23 21:16:02 2018 Return-Path: X-Original-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id BD3601F17C for ; Thu, 23 Aug 2018 21:16:02 +0000 (UTC) Received: (qmail 80125 invoked by uid 500); 23 Aug 2018 21:16:02 -0000 Delivered-To: apmail-hadoop-yarn-issues-archive@hadoop.apache.org Received: (qmail 80067 invoked by uid 500); 23 Aug 2018 21:16:02 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 80056 invoked by uid 99); 23 Aug 2018 21:16:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 23 Aug 2018 21:16:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 34C311807D0 for ; Thu, 23 Aug 2018 21:16:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id MBwlapBNCoRP for ; Thu, 23 Aug 2018 21:16:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id E2E065F396 for ; Thu, 23 Aug 2018 21:16:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 53BD2E0234 for ; Thu, 23 Aug 2018 21:16:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 1353D24693 for ; Thu, 23 Aug 2018 21:16:00 +0000 (UTC) Date: Thu, 23 Aug 2018 21:16:00 +0000 (UTC) From: "Chandni Singh (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (YARN-8706) DelayedProcessKiller is executed for Docker containers even though docker stop sends a KILL signal after the specified grace period MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-8706?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:all-tabpanel ] Chandni Singh updated YARN-8706: -------------------------------- Description:=20 {{DockerStopCommand}} adds a grace period of 10 seconds. 10 seconds is also the default grace time use by docker stop [https://docs.docker.com/engine/reference/commandline/stop/] Documentation of the docker stop: {quote}the main process inside the container will receive=C2=A0{{SIGTERM}},= and after a grace period,=C2=A0{{SIGKILL}}. {quote} There is a {{DelayedProcessKiller}} in {{ContainerExcecutor}} which execute= s for all containers after a delay when {{sleepDelayBeforeSigKill>0}}. By d= efault this is set to {{250 milliseconds}} and so irrespective of the conta= iner type, it will always get executed. =20 For a docker container, {{docker stop}} takes care of sending a {{SIGKILL}}= after the grace period - when sleepDelayBeforeSigKill > 10 seconds, then there is no point of exec= uting DelayedProcessKiller - when sleepDelayBeforeSigKill < 1 second, then the grace period should be = least, which is 1 second, because anyways we are forcing kill after 250 ms =20 was: {{DockerStopCommand}} adds a grace period of 10 seconds. 10 seconds is also the default grace time use by docker stop [https://docs.docker.com/engine/reference/commandline/stop/] Documentation of the docker stop: {quote}the main process inside the container will receive=C2=A0{{SIGTERM}},= and after a grace period,=C2=A0{{SIGKILL}}. {quote} There is a {{DelayedProcessKiller}} in {{ContainerExcecutor}} which execute= s for all containers after a delay when {{sleepDelayBeforeSigKill>0}}. By d= efault this is set to {{250 milliseconds}} and so irrespective of the conta= iner type, it will get always get executed. =20 For a docker container, {{docker stop}} takes care of sending a {{SIGKILL}}= after the grace period, so having {{DelayedProcessKiller}} seems redundant= . > DelayedProcessKiller is executed for Docker containers even though docker= stop sends a KILL signal after the specified grace period > -------------------------------------------------------------------------= ---------------------------------------------------------- > > Key: YARN-8706 > URL: https://issues.apache.org/jira/browse/YARN-8706 > Project: Hadoop YARN > Issue Type: Sub-task > Reporter: Chandni Singh > Assignee: Chandni Singh > Priority: Major > Labels: docker > > {{DockerStopCommand}} adds a grace period of 10 seconds. > 10 seconds is also the default grace time use by docker stop > [https://docs.docker.com/engine/reference/commandline/stop/] > Documentation of the docker stop: > {quote}the main process inside the container will receive=C2=A0{{SIGTERM}= }, and after a grace period,=C2=A0{{SIGKILL}}. > {quote} > There is a {{DelayedProcessKiller}} in {{ContainerExcecutor}} which execu= tes for all containers after a delay when {{sleepDelayBeforeSigKill>0}}. By= default this is set to {{250 milliseconds}} and so irrespective of the con= tainer type, it will always get executed. > =20 > For a docker container, {{docker stop}} takes care of sending a {{SIGKILL= }} after the grace period > - when sleepDelayBeforeSigKill > 10 seconds, then there is no point of ex= ecuting DelayedProcessKiller > - when sleepDelayBeforeSigKill < 1 second, then the grace period should b= e least, which is 1 second, because anyways we are forcing kill after 250 m= s > =20 -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: yarn-issues-help@hadoop.apache.org