hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Subru Krishnan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-8637) [GPG] Add FederationStateStore getAppInfo API for GlobalPolicyGenerator
Date Thu, 09 Aug 2018 01:00:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-8637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16574087#comment-16574087
] 

Subru Krishnan commented on YARN-8637:
--------------------------------------

Thanks [~botong] for the patch. lt looks mostly good, have a minor comments:
 * Set the default to either in-memory or ZK (essentially keep it consistent with current
*FederationStateStore* configs) as SQL dependency shouldn't be expected out of the box. Also,
don't see the need to add a value in yarn-default.
 * Implementation for ZK is missing.
 * Please add a test for the in-memory impl as well.
 * I feel we should some other name than *ApplicationsInfo* (and corresponding getters/setter)
as that looks too close to *AppInfo*? I am worried it may cause some confusion.

> [GPG] Add FederationStateStore getAppInfo API for GlobalPolicyGenerator
> -----------------------------------------------------------------------
>
>                 Key: YARN-8637
>                 URL: https://issues.apache.org/jira/browse/YARN-8637
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Botong Huang
>            Assignee: Botong Huang
>            Priority: Major
>         Attachments: YARN-8637-YARN-7402.v1.patch
>
>
> The core api for FederationStateStore is provided in _FederationStateStore_. In this
patch, we are added a _FederationGPGStateStore_ api just for GPG. Specifically, we are adding
the API to get full application info from statestore with the starting timestamp of the app
entry, so that the _ApplicationCleaner_ (YARN-7599) in GPG can delete and cleanup old entries
in the table. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message