hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Konstantinos Karanasos (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-7953) [GQ] Data structures for federation global queues calculations
Date Thu, 09 Aug 2018 07:39:01 GMT

    [ https://issues.apache.org/jira/browse/YARN-7953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16574418#comment-16574418
] 

Konstantinos Karanasos commented on YARN-7953:
----------------------------------------------

Thanks [~abmodi] for working on this. A few comments on the latest patch:
 * Can we improve a bit the {{propagate}} method of the {{FederationQueue}}? The name is not
very informative and also it does two things, that is, propagate total capacity top-down,
and propagate the rest of the metrics bottom-up. Let's split that into two methods, one
for bottom-up and one for top-down. Then we can keep the propagate (call it propagateCapacities?)
that will call both.
 * Some public methods of FederationQueue do not have comments, including propagate, rollupIdealAssignedFromChildren,
countQueues, etc. Same for the FedQueueIterator class (it creates an iterator to go over
all queues of a FederationQueue hierarchy).
 * [minor] In the first two classes of the patch: This class represent -> This class
represents
 * Do we need all three json files for the tests?

> [GQ] Data structures for federation global queues calculations
> --------------------------------------------------------------
>
>                 Key: YARN-7953
>                 URL: https://issues.apache.org/jira/browse/YARN-7953
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Carlo Curino
>            Assignee: Abhishek Modi
>            Priority: Major
>         Attachments: YARN-7953-YARN-7402.v1.patch, YARN-7953-YARN-7402.v2.patch, YARN-7953-YARN-7402.v3.patch,
YARN-7953-YARN-7402.v4.patch, YARN-7953-YARN-7402.v5.patch, YARN-7953-YARN-7402.v6.patch,
YARN-7953-YARN-7402.v7.patch, YARN-7953.v1.patch
>
>
> This Jira tracks data structures and helper classes used by the core algorithms of YARN-7402
umbrella Jira (currently YARN-7403, and YARN-7834).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message