hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "genericqa (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-8506) Make GetApplicationsRequestPBImpl thread safe
Date Mon, 09 Jul 2018 16:51:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-8506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16537229#comment-16537229
] 

genericqa commented on YARN-8506:
---------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m  0s{color} | {color:blue}
Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red}  0m  6s{color} | {color:red}
YARN-8506 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute
for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | YARN-8506 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12930870/YARN-8506.001.patch
|
| Console output | https://builds.apache.org/job/PreCommit-YARN-Build/21190/console |
| Powered by | Apache Yetus 0.8.0-SNAPSHOT   http://yetus.apache.org |


This message was automatically generated.



> Make GetApplicationsRequestPBImpl thread safe
> ---------------------------------------------
>
>                 Key: YARN-8506
>                 URL: https://issues.apache.org/jira/browse/YARN-8506
>             Project: Hadoop YARN
>          Issue Type: Task
>            Reporter: Wangda Tan
>            Assignee: Wangda Tan
>            Priority: Critical
>         Attachments: YARN-8506.001.patch
>
>
> When GetApplicationRequestPBImpl is used in multi-thread environment, exceptions like
below will occur because we don't protect write ops.
> {code}
> java.lang.ArrayIndexOutOfBoundsException
> 	at java.lang.System.arraycopy(Native Method)
> 	at java.util.ArrayList.addAll(ArrayList.java:613)
> 	at com.google.protobuf.LazyStringArrayList.addAll(LazyStringArrayList.java:132)
> 	at com.google.protobuf.LazyStringArrayList.addAll(LazyStringArrayList.java:123)
> 	at com.google.protobuf.AbstractMessageLite$Builder.addAll(AbstractMessageLite.java:327)
> 	at org.apache.hadoop.yarn.proto.YarnServiceProtos$GetApplicationsRequestProto$Builder.addAllApplicationTags(YarnServiceProtos.java:24450)
> 	at org.apache.hadoop.yarn.api.protocolrecords.impl.pb.GetApplicationsRequestPBImpl.mergeLocalToBuilder(GetApplicationsRequestPBImpl.java:100)
> 	at org.apache.hadoop.yarn.api.protocolrecords.impl.pb.GetApplicationsRequestPBImpl.mergeLocalToProto(GetApplicationsRequestPBImpl.java:78)
> 	at org.apache.hadoop.yarn.api.protocolrecords.impl.pb.GetApplicationsRequestPBImpl.getProto(GetApplicationsRequestPBImpl.java:69)
> {code}
> We need to make GetApplicationRequestPBImpl thread safe. We saw the issue happens frequently
when RequestHedgingRMFailoverProxyProvider is being used.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message