From yarn-issues-return-147799-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Mon Jun 25 03:51:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id C4E3E180657 for ; Mon, 25 Jun 2018 03:51:03 +0200 (CEST) Received: (qmail 75892 invoked by uid 500); 25 Jun 2018 01:51:02 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 75881 invoked by uid 99); 25 Jun 2018 01:51:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 25 Jun 2018 01:51:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 498BDCD568 for ; Mon, 25 Jun 2018 01:51:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id Knu33VOAPt2x for ; Mon, 25 Jun 2018 01:51:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 5B2495F19D for ; Mon, 25 Jun 2018 01:51:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 9FF11E0F87 for ; Mon, 25 Jun 2018 01:51:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 2A04E23F9A for ; Mon, 25 Jun 2018 01:51:00 +0000 (UTC) Date: Mon, 25 Jun 2018 01:51:00 +0000 (UTC) From: "Hudson (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-8443) Total #VCores in cluster metrics is wrong when CapacityScheduler reserved some containers MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-8443?page=3Dcom.atlassian.= jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16521= 763#comment-16521763 ]=20 Hudson commented on YARN-8443: ------------------------------ SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14472 (See [https= ://builds.apache.org/job/Hadoop-trunk-Commit/14472/]) YARN-8443. Total #VCores in cluster metrics is wrong when (wwei: rev 440140= cea6718229094a3d2b97b9b9bd28b95d9b) * (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-ser= ver-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourceman= ager/webapp/dao/ClusterMetricsInfo.java > Total #VCores in cluster metrics is wrong when CapacityScheduler reserved= some containers > -------------------------------------------------------------------------= ---------------- > > Key: YARN-8443 > URL: https://issues.apache.org/jira/browse/YARN-8443 > Project: Hadoop YARN > Issue Type: Bug > Components: webapp > Affects Versions: 2.9.0, 3.1.0, 3.2.0 > Reporter: Tao Yang > Assignee: Tao Yang > Priority: Major > Fix For: 3.2.0, 3.1.1, 3.0.4 > > Attachments: YARN-8443.001.patch > > > Cluster metrics=C2=A0on the=C2=A0web UI will give wrong Total=C2=A0Vcores= when there is reserved container for CapacityScheduler. > Reference code: > {code:java|title=3DClusterMetricsInfo.java} > if (rs instanceof CapacityScheduler) { > CapacityScheduler cs =3D (CapacityScheduler) rs; > this.totalMB =3D availableMB + allocatedMB + reservedMB; > this.totalVirtualCores =3D > availableVirtualCores + allocatedVirtualCores + containersReser= ved; > ... > } > {code} > The key of this problem is the calculation of totalVirtualCores, {{contai= nersReserved}} is the number of reserved containers, not reserved VCores. T= he correct calculation expression of totalVirtualCores should be (available= VirtualCores + allocatedVirtualCores + reservedVirtualCores) -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: yarn-issues-help@hadoop.apache.org