From yarn-issues-return-147169-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Tue Jun 12 02:57:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 53119180647 for ; Tue, 12 Jun 2018 02:57:04 +0200 (CEST) Received: (qmail 86737 invoked by uid 500); 12 Jun 2018 00:57:03 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 86725 invoked by uid 99); 12 Jun 2018 00:57:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 12 Jun 2018 00:57:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id BAC2CC0366 for ; Tue, 12 Jun 2018 00:57:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id COfjJeEdehpe for ; Tue, 12 Jun 2018 00:57:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 4E07A5F358 for ; Tue, 12 Jun 2018 00:57:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 8939BE02EB for ; Tue, 12 Jun 2018 00:57:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 4AE7321097 for ; Tue, 12 Jun 2018 00:57:00 +0000 (UTC) Date: Tue, 12 Jun 2018 00:57:00 +0000 (UTC) From: "Suma Shivaprasad (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (YARN-8415) TimelineWebServices.getEntity should throw a ForbiddenException(403) instead of 404 when ACL checks fail MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-8415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suma Shivaprasad updated YARN-8415: ----------------------------------- Description: {noformat} private TimelineEntity doGetEntity( String entityType, String entityId, EnumSet fields, UserGroupInformation callerUGI) throws YarnException, IOException { TimelineEntity entity = null; entity = store.getEntity(entityId, entityType, fields); if (entity != null) { addDefaultDomainIdIfAbsent(entity); // check ACLs if (!timelineACLsManager.checkAccess( callerUGI, ApplicationAccessType.VIEW_APP, entity)) { *entity = null; //Should differentiate from an entity get failure vs ACL check failure here by throwing an Exception.* } } return entity; } {noformat} was: {noformat} private TimelineEntity doGetEntity( String entityType, String entityId, EnumSet fields, UserGroupInformation callerUGI) throws YarnException, IOException { TimelineEntity entity = null; entity = store.getEntity(entityId, entityType, fields); if (entity != null) { addDefaultDomainIdIfAbsent(entity); // check ACLs if (!timelineACLsManager.checkAccess( callerUGI, ApplicationAccessType.VIEW_APP, entity)) { *entity = null;* //Should differentiate from an entity get failure vs ACL check failure here by throwing an Exception. } } return entity; } {noformat} > TimelineWebServices.getEntity should throw a ForbiddenException(403) instead of 404 when ACL checks fail > -------------------------------------------------------------------------------------------------------- > > Key: YARN-8415 > URL: https://issues.apache.org/jira/browse/YARN-8415 > Project: Hadoop YARN > Issue Type: Bug > Reporter: Suma Shivaprasad > Assignee: Suma Shivaprasad > Priority: Major > > {noformat} > private TimelineEntity doGetEntity( > String entityType, > String entityId, > EnumSet fields, > UserGroupInformation callerUGI) throws YarnException, IOException { > TimelineEntity entity = null; > entity = > store.getEntity(entityId, entityType, fields); > if (entity != null) { > addDefaultDomainIdIfAbsent(entity); > // check ACLs > if (!timelineACLsManager.checkAccess( > callerUGI, ApplicationAccessType.VIEW_APP, entity)) { > *entity = null; //Should differentiate from an entity get failure vs ACL check failure here by throwing an Exception.* > } > } > return entity; > } > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: yarn-issues-help@hadoop.apache.org