From yarn-issues-return-146625-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Fri Jun 1 23:00:06 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 0D8C818063A for ; Fri, 1 Jun 2018 23:00:05 +0200 (CEST) Received: (qmail 75310 invoked by uid 500); 1 Jun 2018 21:00:05 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 75299 invoked by uid 99); 1 Jun 2018 21:00:05 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 01 Jun 2018 21:00:05 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id AA09B1A4D09 for ; Fri, 1 Jun 2018 21:00:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.301 X-Spam-Level: X-Spam-Status: No, score=-110.301 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id LhEHqkyP5Hdg for ; Fri, 1 Jun 2018 21:00:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id A845C5F5FA for ; Fri, 1 Jun 2018 21:00:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 6FAC5E0F75 for ; Fri, 1 Jun 2018 21:00:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 6B63E210A4 for ; Fri, 1 Jun 2018 21:00:00 +0000 (UTC) Date: Fri, 1 Jun 2018 21:00:00 +0000 (UTC) From: "Wangda Tan (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Assigned] (YARN-7962) Race Condition When Stopping DelegationTokenRenewer MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-7962?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:all-tabpanel ] Wangda Tan reassigned YARN-7962: -------------------------------- Assignee: BELUGA BEHR > Race Condition When Stopping DelegationTokenRenewer > --------------------------------------------------- > > Key: YARN-7962 > URL: https://issues.apache.org/jira/browse/YARN-7962 > Project: Hadoop YARN > Issue Type: Bug > Components: resourcemanager > Affects Versions: 3.0.0 > Reporter: BELUGA BEHR > Assignee: BELUGA BEHR > Priority: Critical > Attachments: YARN-7962.1.patch, YARN-7962.2.patch, YARN-7962.3.pa= tch, YARN-7962.4.patch, YARN-7962.6.patch, YARN-7962.7.patch > > > [https://github.com/apache/hadoop/blob/69fa81679f59378fd19a2c65db8019393d= 7c05a2/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-serve= r-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanag= er/security/DelegationTokenRenewer.java] > {code:java} > private ThreadPoolExecutor renewerService; > private void processDelegationTokenRenewerEvent( > DelegationTokenRenewerEvent evt) { > serviceStateLock.readLock().lock(); > try { > if (isServiceStarted) { > renewerService.execute(new DelegationTokenRenewerRunnable(evt)); > } else { > pendingEventQueue.add(evt); > } > } finally { > serviceStateLock.readLock().unlock(); > } > } > @Override > protected void serviceStop() { > if (renewalTimer !=3D null) { > renewalTimer.cancel(); > } > appTokens.clear(); > allTokens.clear(); > this.renewerService.shutdown(); > {code} > {code:java} > 2018-02-21 11:18:16,253 FATAL org.apache.hadoop.yarn.event.AsyncDispatch= er: Error in dispatcher thread > java.util.concurrent.RejectedExecutionException: Task org.apache.hadoop.y= arn.server.resourcemanager.security.DelegationTokenRenewer$DelegationTokenR= enewerRunnable@39bddaf2 rejected from java.util.concurrent.ThreadPoolExecut= or@5f71637b[Terminated, pool size =3D 0, active threads =3D 0, queued tasks= =3D 0, completed tasks =3D 15487] > =09at java.util.concurrent.ThreadPoolExecutor$AbortPolicy.rejectedExecuti= on(ThreadPoolExecutor.java:2048) > =09at java.util.concurrent.ThreadPoolExecutor.reject(ThreadPoolExecutor.j= ava:821) > =09at java.util.concurrent.ThreadPoolExecutor.execute(ThreadPoolExecutor.= java:1372) > =09at org.apache.hadoop.yarn.server.resourcemanager.security.DelegationTo= kenRenewer.processDelegationTokenRenewerEvent(DelegationTokenRenewer.java:1= 96) > =09at org.apache.hadoop.yarn.server.resourcemanager.security.DelegationTo= kenRenewer.applicationFinished(DelegationTokenRenewer.java:734) > =09at org.apache.hadoop.yarn.server.resourcemanager.RMAppManager.finishAp= plication(RMAppManager.java:199) > =09at org.apache.hadoop.yarn.server.resourcemanager.RMAppManager.handle(R= MAppManager.java:424) > =09at org.apache.hadoop.yarn.server.resourcemanager.RMAppManager.handle(R= MAppManager.java:65) > =09at org.apache.hadoop.yarn.event.AsyncDispatcher.dispatch(AsyncDispatch= er.java:177) > =09at org.apache.hadoop.yarn.event.AsyncDispatcher$1.run(AsyncDispatcher.= java:109) > =09at java.lang.Thread.run(Thread.java:745) > {code} > What I think is going on here is that the=C2=A0{{serviceStop}}=C2=A0metho= d is not setting the=C2=A0{{isServiceStarted}}=C2=A0flag to 'false'. > Please update so that the=C2=A0{{serviceStop}}=C2=A0method grabs the=C2= =A0{{serviceStateLock}}=C2=A0and sets=C2=A0{{isServiceStarted}}=C2=A0to=C2= =A0_false_, before shutting down the=C2=A0{{renewerService}}=C2=A0thread po= ol,=C2=A0to avoid this condition. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: yarn-issues-help@hadoop.apache.org