hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Miklos Szegedi (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-8438) TestContainer.testKillOnNew flaky on trunk
Date Fri, 22 Jun 2018 20:46:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-8438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16520758#comment-16520758
] 

Miklos Szegedi commented on YARN-8438:
--------------------------------------

Thank you for the updated patch [~snemeth].

Why do not you use just >= to resolve this?
{code:java}
Assert.assertTrue(
    containerMetrics.finishTime.value() >= containerMetrics.startTime
        .value());{code}

> TestContainer.testKillOnNew flaky on trunk
> ------------------------------------------
>
>                 Key: YARN-8438
>                 URL: https://issues.apache.org/jira/browse/YARN-8438
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: nodemanager
>            Reporter: Szilard Nemeth
>            Assignee: Szilard Nemeth
>            Priority: Major
>         Attachments: YARN-8438.001.patch, YARN-8438.002.patch, YARN-8438.003.patch, YARN-8438.004.patch,
YARN-8438.005.patch
>
>
> Running this test several times (e.g. 30), it fails ~5-10 times.
> Stacktrace: 
> {code:java}
> java.lang.AssertionError at org.junit.Assert.fail(Assert.java:86) at org.junit.Assert.assertTrue(Assert.java:41)
at org.junit.Assert.assertTrue(Assert.java:52) at org.apache.hadoop.yarn.server.nodemanager.containermanager.container.TestContainer.testKillOnNew(TestContainer.java:594)
> {code}
> TestContainer:594 is the following code in trunk, currently:
> {code:java}
> Assert.assertTrue( containerMetrics.finishTime.value() > containerMetrics.startTime
.value());
> {code}
> So sometimes the finish time is not greater than the start time.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message