hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-7449) Split up class TestYarnClient to TestYarnClient and TestYarnClientImpl
Date Sun, 24 Jun 2018 08:05:01 GMT

    [ https://issues.apache.org/jira/browse/YARN-7449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16521422#comment-16521422
] 

Hudson commented on YARN-7449:
------------------------------

FAILURE: Integrated in Jenkins build Hadoop-precommit-ozone-acceptance #20 (See [https://builds.apache.org/job/Hadoop-precommit-ozone-acceptance/20/])
YARN-7449. Split up class TestYarnClient to TestYarnClient and (miklos.szegedi: [https://github.com/apache/hadoop/commit/bbbc7cc426f71ad0fe4174efcd25e5ac3f62b501])
* (add) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/api/impl/TestYarnClientImpl.java
* (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/test/java/org/apache/hadoop/yarn/client/api/impl/TestYarnClient.java


> Split up class TestYarnClient to TestYarnClient and TestYarnClientImpl
> ----------------------------------------------------------------------
>
>                 Key: YARN-7449
>                 URL: https://issues.apache.org/jira/browse/YARN-7449
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: client, yarn
>            Reporter: Yufei Gu
>            Assignee: Szilard Nemeth
>            Priority: Minor
>              Labels: newbie, newbie++
>             Fix For: 3.2.0
>
>         Attachments: YARN-7449-001.patch, YARN-7449.002.patch
>
>
> {{TestYarnClient}} tests both {{YarnClient}} and {{YarnClientImpl}}. We should test {{YarnClient}}
without thinking of its implementation. That's the whole point of {{YarnClient}}. There are
bunch of refactors we could do. The first thing is to Split up class {{TestYarnClient}} to
{{TestYarnClient}} and {{TestYarnClientImpl}}. Let {{TestYarnClient}} only tests {{YarnClient}}.
All implementation related stuff go to  {{TestYarnClientImpl}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message