hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Miklos Szegedi (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-7449) Split up class TestYarnClient to TestYarnClient and TestYarnClientImpl
Date Wed, 20 Jun 2018 18:53:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-7449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16518482#comment-16518482
] 

Miklos Szegedi commented on YARN-7449:
--------------------------------------

+1 LGTM.

> Split up class TestYarnClient to TestYarnClient and TestYarnClientImpl
> ----------------------------------------------------------------------
>
>                 Key: YARN-7449
>                 URL: https://issues.apache.org/jira/browse/YARN-7449
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: client, yarn
>            Reporter: Yufei Gu
>            Assignee: Szilard Nemeth
>            Priority: Minor
>              Labels: newbie, newbie++
>         Attachments: YARN-7449-001.patch, YARN-7449.002.patch
>
>
> {{TestYarnClient}} tests both {{YarnClient}} and {{YarnClientImpl}}. We should test {{YarnClient}}
without thinking of its implementation. That's the whole point of {{YarnClient}}. There are
bunch of refactors we could do. The first thing is to Split up class {{TestYarnClient}} to
{{TestYarnClient}} and {{TestYarnClientImpl}}. Let {{TestYarnClient}} only tests {{YarnClient}}.
All implementation related stuff go to  {{TestYarnClientImpl}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message