From yarn-issues-return-145188-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Wed May 16 01:03:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id BE747180634 for ; Wed, 16 May 2018 01:03:04 +0200 (CEST) Received: (qmail 64833 invoked by uid 500); 15 May 2018 23:03:03 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 64822 invoked by uid 99); 15 May 2018 23:03:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 15 May 2018 23:03:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 2D99BC00A9 for ; Tue, 15 May 2018 23:03:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id Gz4PwcuVweBJ for ; Tue, 15 May 2018 23:03:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 3DE9D5F666 for ; Tue, 15 May 2018 23:03:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 7C133E0CCC for ; Tue, 15 May 2018 23:03:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 2D66D217A1 for ; Tue, 15 May 2018 23:03:00 +0000 (UTC) Date: Tue, 15 May 2018 23:03:00 +0000 (UTC) From: "Giovanni Matteo Fumarola (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-8300) Fix NPE in DefaultUpgradeComponentsFinder MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-8300?page=3Dcom.atlassian.= jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16476= 584#comment-16476584 ]=20 Giovanni Matteo Fumarola commented on YARN-8300: ------------------------------------------------ Thanks [~suma.shivaprasad] for the patch. In {{TestDefaultUpgradeComponentsFinder}} you should code something like th= is. =C2=A0 {code:java} try { finder.findTargetComponentSpecs(currentDef, targetDef); Assert.FAIL();=20 } catch(UnsupportedOperationException usoe) { ASSERT usoe.getError equal to the expected Error }{code} =C2=A0 =C2=A0 > Fix NPE in DefaultUpgradeComponentsFinder=20 > ------------------------------------------ > > Key: YARN-8300 > URL: https://issues.apache.org/jira/browse/YARN-8300 > Project: Hadoop YARN > Issue Type: Bug > Components: yarn > Reporter: Suma Shivaprasad > Assignee: Suma Shivaprasad > Priority: Major > Fix For: 3.1.1 > > Attachments: YARN-8300.1.patch > > > In current upgrades for Yarn native services, we do not support addition/= deletion of compoents during upgrade. On trying to upgrade with the same nu= mber of components in target spec as the current service spec but with the = one of the components having a new target spec and name, see the following = NPE in service AM logs > {noformat} > 2018-05-15 00:10:41,489 [IPC Server handler 0 on 37488] ERROR service.Cli= entAMService - Error while trying to upgrade service {}=20 > java.lang.NullPointerException > =09at org.apache.hadoop.yarn.service.UpgradeComponentsFinder$DefaultUpgra= deComponentsFinder.lambda$findTargetComponentSpecs$0(UpgradeComponentsFinde= r.java:103) > =09at java.util.ArrayList.forEach(ArrayList.java:1257) > =09at org.apache.hadoop.yarn.service.UpgradeComponentsFinder$DefaultUpgra= deComponentsFinder.findTargetComponentSpecs(UpgradeComponentsFinder.java:10= 0) > =09at org.apache.hadoop.yarn.service.ServiceManager.processUpgradeRequest= (ServiceManager.java:259) > =09at org.apache.hadoop.yarn.service.ClientAMService.upgrade(ClientAMServ= ice.java:163) > =09at org.apache.hadoop.yarn.service.impl.pb.service.ClientAMProtocolPBSe= rviceImpl.upgradeService(ClientAMProtocolPBServiceImpl.java:81) > =09at org.apache.hadoop.yarn.proto.ClientAMProtocol$ClientAMProtocolServi= ce$2.callBlockingMethod(ClientAMProtocol.java:5972) > =09at org.apache.hadoop.ipc.ProtobufRpcEngine$Server$ProtoBufRpcInvoker.c= all(ProtobufRpcEngine.java:523) > =09at org.apache.hadoop.ipc.RPC$Server.call(RPC.java:991) > =09at org.apache.hadoop.ipc.Server$RpcCall.run(Server.java:872) > =09at org.apache.hadoop.ipc.Server$RpcCall.run(Server.java:818) > =09at java.security.AccessController.doPrivileged(Native Method) > =09at javax.security.auth.Subject.doAs(Subject.java:422) > =09at org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInfor= mation.java:1682) > =09at org.apache.hadoop.ipc.Server$Handler.run(Server.java:2678) > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: yarn-issues-help@hadoop.apache.org