From yarn-issues-return-143940-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Wed May 2 12:24:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id E3F7B180675 for ; Wed, 2 May 2018 12:24:04 +0200 (CEST) Received: (qmail 10973 invoked by uid 500); 2 May 2018 10:24:04 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 10962 invoked by uid 99); 2 May 2018 10:24:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 May 2018 10:24:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 7DEB7C6F41 for ; Wed, 2 May 2018 10:24:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.301 X-Spam-Level: X-Spam-Status: No, score=-110.301 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id hMV1aYYDe7fv for ; Wed, 2 May 2018 10:24:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 89FB75F58A for ; Wed, 2 May 2018 10:24:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id C5486E0CCB for ; Wed, 2 May 2018 10:24:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 41D802129E for ; Wed, 2 May 2018 10:24:00 +0000 (UTC) Date: Wed, 2 May 2018 10:24:00 +0000 (UTC) From: "Hudson (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-8222) Fix potential NPE when gets RMApp from RM context MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-8222?page=3Dcom.atlassian.= jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16460= 830#comment-16460830 ]=20 Hudson commented on YARN-8222: ------------------------------ SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14108 (See [https= ://builds.apache.org/job/Hadoop-trunk-Commit/14108/]) YARN-8222. Fix potential NPE when gets RMApp from RM context. (wwei: rev 25= 1f528814c4a4647cac0af6effb9a73135db180) * (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-ser= ver-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourceman= ager/rmcontainer/RMContainerImpl.java * (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-ser= ver-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourceman= ager/scheduler/SchedulerApplicationAttempt.java > Fix potential NPE when gets RMApp from RM context > ------------------------------------------------- > > Key: YARN-8222 > URL: https://issues.apache.org/jira/browse/YARN-8222 > Project: Hadoop YARN > Issue Type: Bug > Affects Versions: 3.2.0 > Reporter: Tao Yang > Assignee: Tao Yang > Priority: Critical > Fix For: 3.2.0, 3.1.1, 3.0.3 > > Attachments: YARN-8222.001.patch > > > Recently we did some performance tests and found two NPE problems when ca= lling rmContext.getRMApps().get(appId).get... > These NPE problems occasionally happened when doing performance tests wit= h large number and fast-finished applications. We have checked other places= which call rmContext.getRMApps().get(...), most of them have null check an= d some does not need (The process can guarantee that the return result will= not be null).=20 > To fix these problems, We can add a null check for application before get= ting attempt form it. > (1) NPE in RMContainerImpl$FinishedTransition#updateAttemptMetrics > {noformat} > java.lang.NullPointerException > =C2=A0 =C2=A0 =C2=A0 =C2=A0 at org.apache.hadoop.yarn.server.resourcemana= ger.rmcontainer.RMContainerImpl$FinishedTransition.updateAttemptMetrics(RMC= ontainerImpl.java:742) > =C2=A0 =C2=A0 =C2=A0 =C2=A0 at org.apache.hadoop.yarn.server.resourcemana= ger.rmcontainer.RMContainerImpl$FinishedTransition.transition(RMContainerIm= pl.java:715) > =C2=A0 =C2=A0 =C2=A0 =C2=A0 at org.apache.hadoop.yarn.server.resourcemana= ger.rmcontainer.RMContainerImpl$FinishedTransition.transition(RMContainerIm= pl.java:699) > =C2=A0 =C2=A0 =C2=A0 =C2=A0 at org.apache.hadoop.yarn.state.StateMachineF= actory$SingleInternalArc.doTransition(StateMachineFactory.java:362) > =C2=A0 =C2=A0 =C2=A0 =C2=A0 at org.apache.hadoop.yarn.state.StateMachineF= actory.doTransition(StateMachineFactory.java:302) > =C2=A0 =C2=A0 =C2=A0 =C2=A0 at org.apache.hadoop.yarn.state.StateMachineF= actory.access$500(StateMachineFactory.java:46) > =C2=A0 =C2=A0 =C2=A0 =C2=A0 at org.apache.hadoop.yarn.state.StateMachineF= actory$InternalStateMachine.doTransition(StateMachineFactory.java:487) > =C2=A0 =C2=A0 =C2=A0 =C2=A0 at org.apache.hadoop.yarn.server.resourcemana= ger.rmcontainer.RMContainerImpl.handle(RMContainerImpl.java:482) > =C2=A0 =C2=A0 =C2=A0 =C2=A0 at org.apache.hadoop.yarn.server.resourcemana= ger.rmcontainer.RMContainerImpl.handle(RMContainerImpl.java:64) > =C2=A0 =C2=A0 =C2=A0 =C2=A0 at org.apache.hadoop.yarn.server.resourcemana= ger.scheduler.common.fica.FiCaSchedulerApp.containerCompleted(FiCaScheduler= App.java:195) > =C2=A0 =C2=A0 =C2=A0 =C2=A0 at org.apache.hadoop.yarn.server.resourcemana= ger.scheduler.capacity.LeafQueue.completedContainer(LeafQueue.java:1793) > =C2=A0 =C2=A0 =C2=A0 =C2=A0 at org.apache.hadoop.yarn.server.resourcemana= ger.scheduler.capacity.CapacityScheduler.completedContainerInternal(Capacit= yScheduler.java:2624) > =C2=A0 =C2=A0 =C2=A0 =C2=A0 at org.apache.hadoop.yarn.server.resourcemana= ger.scheduler.AbstractYarnScheduler.completedContainer(AbstractYarnSchedule= r.java:663) > =C2=A0 =C2=A0 =C2=A0 =C2=A0 at org.apache.hadoop.yarn.server.resourcemana= ger.scheduler.capacity.CapacityScheduler.doneApplicationAttempt(CapacitySch= eduler.java:1514) > =C2=A0 =C2=A0 =C2=A0 =C2=A0 at org.apache.hadoop.yarn.server.resourcemana= ger.scheduler.capacity.CapacityScheduler.handle(CapacityScheduler.java:2396= ) > =C2=A0 =C2=A0 =C2=A0 =C2=A0 at org.apache.hadoop.yarn.sls.scheduler.SLSCa= pacityScheduler.handle(SLSCapacityScheduler.java:205) > =C2=A0 =C2=A0 =C2=A0 =C2=A0 at org.apache.hadoop.yarn.sls.scheduler.SLSCa= pacityScheduler.handle(SLSCapacityScheduler.java:60) > =C2=A0 =C2=A0 =C2=A0 =C2=A0 at org.apache.hadoop.yarn.event.EventDispatch= er$EventProcessor.run(EventDispatcher.java:66) > =C2=A0 =C2=A0 =C2=A0 =C2=A0 at java.lang.Thread.run(Thread.java:834) > {noformat} > This NPE looks like happen when node heartbeat delay and try to update at= tempt metrics for a non-exist app.=20 > Reference code of RMContainerImpl$FinishedTransition#updateAttemptMetrics= : > {code:java} > private static void updateAttemptMetrics(RMContainerImpl container) { > Resource resource =3D container.getContainer().getResource(); > RMAppAttempt rmAttempt =3D container.rmContext.getRMApps() > .get(container.getApplicationAttemptId().getApplicationId()) > .getCurrentAppAttempt(); > if (rmAttempt !=3D null) { > //.... > } > } > {code} > (2) NPE in SchedulerApplicationAttempt#incNumAllocatedContainers > {noformat} > java.lang.NullPointerException > at org.apache.hadoop.yarn.server.resourcemanager.scheduler.Schedu= lerApplicationAttempt.incNumAllocatedContainers(SchedulerApplicationAttempt= .java:1268) > at org.apache.hadoop.yarn.server.resourcemanager.scheduler.common= .fica.FiCaSchedulerApp.apply(FiCaSchedulerApp.java:638) > at org.apache.hadoop.yarn.server.resourcemanager.scheduler.capaci= ty.CapacityScheduler.tryCommit(CapacityScheduler.java:3589) > at org.apache.hadoop.yarn.sls.scheduler.SLSCapacityScheduler.tryC= ommit(SLSCapacityScheduler.java:142) > at org.apache.hadoop.yarn.server.resourcemanager.scheduler.capaci= ty.CapacityScheduler$ResourceCommitterService.run(CapacityScheduler.java:96= 2) > {noformat} > This NPE should happen when apply a outdated proposal for a non-existed a= pplication in rmContext. > Reference code: > {code:java} > RMAppAttempt attempt =3D > rmContext.getRMApps().get(attemptId.getApplicationId()) > .getCurrentAppAttempt(); > if (attempt !=3D null) { > attempt.getRMAppAttemptMetrics().incNumAllocatedContainers(containe= rType, > requestType); > } > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: yarn-issues-help@hadoop.apache.org