From yarn-issues-return-143944-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Wed May 2 15:15:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id DB09E18065D for ; Wed, 2 May 2018 15:15:04 +0200 (CEST) Received: (qmail 32051 invoked by uid 500); 2 May 2018 13:15:03 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 32040 invoked by uid 99); 2 May 2018 13:15:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 May 2018 13:15:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 79E39C0354 for ; Wed, 2 May 2018 13:15:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id mru14FSLQkwY for ; Wed, 2 May 2018 13:15:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id D876C5F39E for ; Wed, 2 May 2018 13:15:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 64174E0257 for ; Wed, 2 May 2018 13:15:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 2AFD821299 for ; Wed, 2 May 2018 13:15:00 +0000 (UTC) Date: Wed, 2 May 2018 13:15:00 +0000 (UTC) From: "genericqa (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-8202) DefaultAMSProcessor should properly check units of requested custom resource types against minimum/maximum allocation MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-8202?page=3Dcom.atlassian.= jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16461= 003#comment-16461003 ]=20 genericqa commented on YARN-8202: --------------------------------- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 19s= {color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0= m 1s{color} | {color:green} The patch does not contain any @author tags. {= color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green}= 0m 0s{color} | {color:green} The patch appears to include 5 new or modif= ied test files. {color} | || || || || {color:brown} trunk Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 2m 24s= {color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}= 27m 15s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 28= m 37s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}= 3m 16s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 4= m 5s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:gree= n} 18m 20s{color} | {color:green} branch has no errors when building and te= sting our client artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} = 6m 9s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3= m 7s{color} | {color:green} trunk passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 17s= {color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}= 3m 8s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 26= m 23s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 26m = 23s{color} | {color:green} the patch passed {color} | | {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:oran= ge} 3m 11s{color} | {color:orange} root: The patch generated 1 new + 122 u= nchanged - 95 fixed =3D 123 total (was 217) {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 3= m 42s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green}= 0m 0s{color} | {color:green} The patch has no whitespace issues. {color}= | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:gree= n} 10m 25s{color} | {color:green} patch has no errors when building and tes= ting our client artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} = 6m 27s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2= m 55s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 4= 6s{color} | {color:green} hadoop-yarn-api in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m 1= 0s{color} | {color:green} hadoop-yarn-common in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 1= 0s{color} | {color:green} hadoop-yarn-server-common in the patch passed. {c= olor} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 62m 2= 7s{color} | {color:green} hadoop-yarn-server-resourcemanager in the patch p= assed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 9m 1= 0s{color} | {color:green} hadoop-mapreduce-client-app in the patch passed. = {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green}= 0m 41s{color} | {color:green} The patch does not generate ASF License war= nings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}224m 6s{colo= r} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=3D17.05.0-ce Server=3D17.05.0-ce Image:yetus/hadoop:abb62= dd | | JIRA Issue | YARN-8202 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/1292156= 7/YARN-8202-008.patch | | Optional Tests | asflicense compile javac javadoc mvninstall mvnsit= e unit shadedclient findbugs checkstyle | | uname | Linux c254f8d51f42 3.13.0-139-generic #188-Ubuntu SMP Tue Jan 9 1= 4:43:09 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | trunk / 3265b55 | | maven | version: Apache Maven 3.3.9 | | Default Java | 1.8.0_162 | | findbugs | v3.1.0-RC1 | | checkstyle | https://builds.apache.org/job/PreCommit-YARN-Build/20569/art= ifact/out/diff-checkstyle-root.txt | | Test Results | https://builds.apache.org/job/PreCommit-YARN-Build/20569/= testReport/ | | Max. process+thread count | 863 (vs. ulimit of 10000) | | modules | C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-= project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hado= op-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/ha= doop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-mapreduce-projec= t/hadoop-mapreduce-client/hadoop-mapreduce-client-app U: . | | Console output | https://builds.apache.org/job/PreCommit-YARN-Build/20569= /console | | Powered by | Apache Yetus 0.8.0-SNAPSHOT http://yetus.apache.org | This message was automatically generated. > DefaultAMSProcessor should properly check units of requested custom resou= rce types against minimum/maximum allocation > -------------------------------------------------------------------------= -------------------------------------------- > > Key: YARN-8202 > URL: https://issues.apache.org/jira/browse/YARN-8202 > Project: Hadoop YARN > Issue Type: Bug > Reporter: Szilard Nemeth > Assignee: Szilard Nemeth > Priority: Blocker > Attachments: YARN-8202-001.patch, YARN-8202-002.patch, YARN-8202-= 003.patch, YARN-8202-004.patch, YARN-8202-005.patch, YARN-8202-006.patch, Y= ARN-8202-007.patch, YARN-8202-008.patch > > > =C2=A0 > When I execute a pi job with arguments:=C2=A0 > {code:java} > -Dmapreduce.map.resource.memory-mb=3D200 -Dmapreduce.map.resource.resourc= e1=3D500M 1 1000{code} > and I have one node with 5GB of resource1, I get the following exception = on every second and the job hangs: > {code:java} > 2018-04-24 08:42:03,694 INFO org.apache.hadoop.ipc.Server: IPC Server han= dler 20 on 8030, call Call#386 Retry#0 org.apache.hadoop.yarn.api.Applicati= onMasterProtocolPB.allocate from 172.31.119.172:58138 > org.apache.hadoop.yarn.exceptions.InvalidResourceRequestException: Invali= d resource request, requested resource type=3D[resource1] < 0 or greater th= an maximum allowed allocation. Requested resource=3D, maximum allowed allocation=3D, please note that maximum allowed allocation is calculated by sc= heduler based on maximum resource of registered NodeManagers, which might b= e less than configured maximum allocation=3D > =C2=A0 =C2=A0 =C2=A0 =C2=A0 at org.apache.hadoop.yarn.server.resourcemana= ger.scheduler.SchedulerUtils.validateResourceRequest(SchedulerUtils.java:28= 6) > =C2=A0 =C2=A0 =C2=A0 =C2=A0 at org.apache.hadoop.yarn.server.resourcemana= ger.scheduler.SchedulerUtils.normalizeAndValidateRequest(SchedulerUtils.jav= a:242) > =C2=A0 =C2=A0 =C2=A0 =C2=A0 at org.apache.hadoop.yarn.server.resourcemana= ger.scheduler.SchedulerUtils.normalizeAndvalidateRequest(SchedulerUtils.jav= a:258) > =C2=A0 =C2=A0 =C2=A0 =C2=A0 at org.apache.hadoop.yarn.server.resourcemana= ger.RMServerUtils.normalizeAndValidateRequests(RMServerUtils.java:249) > =C2=A0 =C2=A0 =C2=A0 =C2=A0 at org.apache.hadoop.yarn.server.resourcemana= ger.DefaultAMSProcessor.allocate(DefaultAMSProcessor.java:230) > =C2=A0 =C2=A0 =C2=A0 =C2=A0 at org.apache.hadoop.yarn.server.resourcemana= ger.scheduler.constraint.processor.DisabledPlacementProcessor.allocate(Disa= bledPlacementProcessor.java:75) > =C2=A0 =C2=A0 =C2=A0 =C2=A0 at org.apache.hadoop.yarn.server.resourcemana= ger.AMSProcessingChain.allocate(AMSProcessingChain.java:92) > =C2=A0 =C2=A0 =C2=A0 =C2=A0 at org.apache.hadoop.yarn.server.resourcemana= ger.ApplicationMasterService.allocate(ApplicationMasterService.java:433) > =C2=A0 =C2=A0 =C2=A0 =C2=A0 at org.apache.hadoop.yarn.api.impl.pb.service= .ApplicationMasterProtocolPBServiceImpl.allocate(ApplicationMasterProtocolP= BServiceImpl.java:60) > =C2=A0 =C2=A0 =C2=A0 =C2=A0 at org.apache.hadoop.yarn.proto.ApplicationMa= sterProtocol$ApplicationMasterProtocolService$2.callBlockingMethod(Applicat= ionMasterProtocol.java:99) > =C2=A0 =C2=A0 =C2=A0 =C2=A0 at org.apache.hadoop.ipc.ProtobufRpcEngine$Se= rver$ProtoBufRpcInvoker.call(ProtobufRpcEngine.java:523) > =C2=A0 =C2=A0 =C2=A0 =C2=A0 at org.apache.hadoop.ipc.RPC$Server.call(RPC.= java:991) > =C2=A0 =C2=A0 =C2=A0 =C2=A0 at org.apache.hadoop.ipc.Server$RpcCall.run(S= erver.java:872) > =C2=A0 =C2=A0 =C2=A0 =C2=A0 at org.apache.hadoop.ipc.Server$RpcCall.run(S= erver.java:818) > =C2=A0 =C2=A0 =C2=A0 =C2=A0 at java.security.AccessController.doPrivilege= d(Native Method) > =C2=A0 =C2=A0 =C2=A0 =C2=A0 at javax.security.auth.Subject.doAs(Subject.j= ava:422) > =C2=A0 =C2=A0 =C2=A0 =C2=A0 at org.apache.hadoop.security.UserGroupInform= ation.doAs(UserGroupInformation.java:1682) > =C2=A0 =C2=A0 =C2=A0 =C2=A0 at org.apache.hadoop.ipc.Server$Handler.run(S= erver.java:2678) > {code} > *This is because=C2=A0org.apache.hadoop.yarn.server.resourcemanager.sched= uler.SchedulerUtils#validateResourceRequest does not take resource units in= to account.* > =C2=A0 > However, if I start a job with arguments:=C2=A0 > {code:java} > -Dmapreduce.map.resource.memory-mb=3D200 -Dmapreduce.map.resource.resourc= e1=3D1G 1 1000{code} > and I still have 5GB of resource1 on one node then the job runs successfu= lly. > =C2=A0 > I also tried a third=C2=A0job run, when I request 1GB of resource1 and I = have no nodes with any amount of resource1, then I restart the node with 5G= Bs of resource1, the job ultimately completes, but just after the node with= enough resources registered in RM, which is the desired behaviour. > =C2=A0 -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: yarn-issues-help@hadoop.apache.org