From yarn-issues-return-144735-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Thu May 10 17:45:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 1845E180718 for ; Thu, 10 May 2018 17:45:04 +0200 (CEST) Received: (qmail 59687 invoked by uid 500); 10 May 2018 15:45:04 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 59676 invoked by uid 99); 10 May 2018 15:45:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 10 May 2018 15:45:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 15A31180857 for ; Thu, 10 May 2018 15:45:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.311 X-Spam-Level: X-Spam-Status: No, score=-110.311 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id DW3GOUzOj-JO for ; Thu, 10 May 2018 15:45:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 002C55FBF7 for ; Thu, 10 May 2018 15:45:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 663C8E0F3E for ; Thu, 10 May 2018 15:45:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id A469821555 for ; Thu, 10 May 2018 15:45:00 +0000 (UTC) Date: Thu, 10 May 2018 15:45:00 +0000 (UTC) From: "Gergo Repas (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-8191) Fair scheduler: queue deletion without RM restart MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-8191?page=3Dcom.atlassian.= jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16470= 570#comment-16470570 ]=20 Gergo Repas commented on YARN-8191: ----------------------------------- [~wilfreds] Thank you for the review! I have a question regarding two point= s, and I have addressed the rest of the points: * Can we add a test for this case please? I do not see this specific case i= n the tests covered, testNonEmptyStaticQueueBecomingDynamicQueue does not c= over this use case=20 ** I have added testRemovalOfChildlessParentQueue() to test this scenario. * We already check all queues defined in the configuration on each reload f= or existence in the updateAllocationConfiguration via the call to removeEmp= tyIncompatibleQueues. If the queue of the correct type exists we currently = just return. The only thing we should do now before we return is unset the = isDynamic flag there and there is no need for a separate loop. removeEmptyI= ncompatibleQueues is called for each configured queue with each reload. ** Sorry, I do not understand what you're suggesting here. Could you please= elaborate a bit more? * Keeping the same list in two places does not make sense. You now need to = keep them in sync and it complicates the code in updateAllocationConfigurat= ion which is not needed. We have also seen clusters with 100's of dynamic q= ueues when user based queues are used so the loops can become long. Please = move the logic for generating the diff to the onReload method where we have= the 2 copies as described above. ** I moved the logic into onReload. * In assertNotNull should use the q1 object that is returned, multiple test= s ** Fixed. * testRemovalOfDynamicLeafQueue needs to cover a dynamic leaf queue removal= which has a static parent, and make sure the parent is still there. It sho= uld also check if a non empty queue is not removed. ** Good point, fixed. * testRemovalOfDynamicParentQueue needs to cover a dynamic parent queue wit= hout a leaf is removal. ** How can I create a dynamic parent queue without a leaf? I thought the on= ly way to have a parent queue without a leaf is to add it to the allocation= config with parent=3D"true", but in this case it'd be a static queue. * testNonEmptyDynamicQueueBecomingStaticQueue is missing a check after the = configuration update for isDynamic or not. The test name does not really co= ver the test you do unless you do that. The queue being empty or not does n= ot really matter. ** Good point, fixed. * testNonEmptyStaticQueueBecomingDynamicQueue: "root.test.childA" is shown = as "root.queue1 is not a static queue" in the assert message. Check the ord= er and comments in the method, they seem a bit out of order. ** Thanks, fixed. * We need to cover a parent queue in the tests: dynamic parent + dynamic le= af (no apps) changing to static. Leaf and parent must be static after the c= hange and the other way around (testQueueTypeChange ?) ** Good idea, I've added testQueueTypeChange(). * We need a test for the updating of the assignedApp in the FSLeafQueue and= make sure isEmpty is working OK. ** Right, I've added testApplicationAssignmentPreventsRemovalOfDynamicQueue= () (I'm open for suggestions regarding the naming). > Fair scheduler: queue deletion without RM restart > ------------------------------------------------- > > Key: YARN-8191 > URL: https://issues.apache.org/jira/browse/YARN-8191 > Project: Hadoop YARN > Issue Type: Improvement > Components: fairscheduler > Affects Versions: 3.0.1 > Reporter: Gergo Repas > Assignee: Gergo Repas > Priority: Major > Attachments: Queue Deletion in Fair Scheduler.pdf, YARN-8191.000.= patch, YARN-8191.001.patch, YARN-8191.002.patch, YARN-8191.003.patch, YARN-= 8191.004.patch, YARN-8191.005.patch, YARN-8191.006.patch, YARN-8191.007.pat= ch, YARN-8191.008.patch, YARN-8191.009.patch > > > The Fair Scheduler never cleans up queues even if they are deleted in the= allocation file, or were dynamically created and are never going to be use= d again. Queues always remain in memory which leads to two following issues= . > # Steady fairshares aren=E2=80=99t calculated correctly due to remaining= queues > # WebUI shows deleted queues, which is confusing for users (YARN-4022). > We want to support proper queue deletion without restarting the Resource = Manager: > # Static queues without any entries that are removed from fair-scheduler= .xml should be deleted from memory. > # Dynamic queues without any entries should be deleted. > # RM Web UI should only show the queues defined in the scheduler at that= point in time. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: yarn-issues-help@hadoop.apache.org