From yarn-issues-return-144122-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Thu May 3 15:43:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 377C4180677 for ; Thu, 3 May 2018 15:43:04 +0200 (CEST) Received: (qmail 71313 invoked by uid 500); 3 May 2018 13:43:03 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 71300 invoked by uid 99); 3 May 2018 13:43:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 03 May 2018 13:43:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 76BBFC85AD for ; Thu, 3 May 2018 13:43:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.301 X-Spam-Level: X-Spam-Status: No, score=-110.301 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id RxlvM9GFuul1 for ; Thu, 3 May 2018 13:43:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 28C165FB92 for ; Thu, 3 May 2018 13:43:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 7E9A7E0CA4 for ; Thu, 3 May 2018 13:43:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 3C1C12129B for ; Thu, 3 May 2018 13:43:00 +0000 (UTC) Date: Thu, 3 May 2018 13:43:00 +0000 (UTC) From: "genericqa (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-7892) Revisit NodeAttribute class structure MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-7892?page=3Dcom.atlassian.= jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16462= 459#comment-16462459 ]=20 genericqa commented on YARN-7892: --------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 36s= {color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0= m 0s{color} | {color:green} The patch does not contain any @author tags. {= color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green}= 0m 0s{color} | {color:green} The patch appears to include 7 new or modif= ied test files. {color} | || || || || {color:brown} YARN-3409 Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 20s= {color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}= 26m 6s{color} | {color:green} YARN-3409 passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 29= m 56s{color} | {color:green} YARN-3409 passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}= 3m 17s{color} | {color:green} YARN-3409 passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 4= m 43s{color} | {color:green} YARN-3409 passed {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:gree= n} 19m 4s{color} | {color:green} branch has no errors when building and te= sting our client artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} = 7m 0s{color} | {color:green} YARN-3409 passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3= m 19s{color} | {color:green} YARN-3409 passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 20s= {color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}= 3m 51s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 28= m 15s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} cc {color} | {color:green} 28m 15s= {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 28m = 15s{color} | {color:green} the patch passed {color} | | {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:oran= ge} 3m 12s{color} | {color:orange} root: The patch generated 9 new + 219 u= nchanged - 1 fixed =3D 228 total (was 220) {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 4= m 31s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m = 0s{color} | {color:red} The patch has 2 line(s) that end in whitespace. Use= git apply --whitespace=3Dfix <>. Refer https://git-scm.com/doc= s/git-apply {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:gree= n} 9m 56s{color} | {color:green} patch has no errors when building and tes= ting our client artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} = 7m 42s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m 37s{= color} | {color:red} hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_had= oop-yarn-server-resourcemanager generated 1 new + 4 unchanged - 0 fixed =3D= 5 total (was 4) {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 5= 2s{color} | {color:green} hadoop-yarn-api in the patch passed. {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 3m 34s{col= or} | {color:red} hadoop-yarn-common in the patch failed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 20m = 4s{color} | {color:green} hadoop-yarn-server-nodemanager in the patch passe= d. {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 69m 44s{col= or} | {color:red} hadoop-yarn-server-resourcemanager in the patch failed. {= color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 25m 48s{col= or} | {color:red} hadoop-yarn-client in the patch failed. {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red}154m 35s{col= or} | {color:red} hadoop-mapreduce-client-jobclient in the patch failed. {c= olor} | | {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 1m 3= 4s{color} | {color:red} The patch generated 1 ASF License warnings. {color}= | | {color:black}{color} | {color:black} {color} | {color:black}426m 46s{colo= r} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | hadoop.yarn.api.resource.TestPlacementConstraintTran= sformations | | | hadoop.yarn.server.resourcemanager.scheduler.capacity.TestIncreaseAll= ocationExpirer | | | hadoop.yarn.client.api.impl.TestAMRMProxy | | | hadoop.hdfs.TestNNBench | \\ \\ || Subsystem || Report/Notes || | Docker | Client=3D17.05.0-ce Server=3D17.05.0-ce Image:yetus/hadoop:abb62= dd | | JIRA Issue | YARN-7892 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/1292166= 8/YARN-7892-YARN-3409.005.patch | | Optional Tests | asflicense compile javac javadoc mvninstall mvnsit= e unit shadedclient findbugs checkstyle cc | | uname | Linux 35cf195ce651 3.13.0-139-generic #188-Ubuntu SMP Tue Jan 9 1= 4:43:09 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | YARN-3409 / 011795f | | maven | version: Apache Maven 3.3.9 | | Default Java | 1.8.0_162 | | findbugs | v3.1.0-RC1 | | checkstyle | https://builds.apache.org/job/PreCommit-YARN-Build/20579/art= ifact/out/diff-checkstyle-root.txt | | whitespace | https://builds.apache.org/job/PreCommit-YARN-Build/20579/art= ifact/out/whitespace-eol.txt | | javadoc | https://builds.apache.org/job/PreCommit-YARN-Build/20579/artifa= ct/out/diff-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-ser= ver_hadoop-yarn-server-resourcemanager.txt | | unit | https://builds.apache.org/job/PreCommit-YARN-Build/20579/artifact/= out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt | | unit | https://builds.apache.org/job/PreCommit-YARN-Build/20579/artifact/= out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-ya= rn-server-resourcemanager.txt | | unit | https://builds.apache.org/job/PreCommit-YARN-Build/20579/artifact/= out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-client.txt | | unit | https://builds.apache.org/job/PreCommit-YARN-Build/20579/artifact/= out/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client_hadoop-mapr= educe-client-jobclient.txt | | Test Results | https://builds.apache.org/job/PreCommit-YARN-Build/20579/= testReport/ | | asflicense | https://builds.apache.org/job/PreCommit-YARN-Build/20579/art= ifact/out/patch-asflicense-problems.txt | | Max. process+thread count | 1200 (vs. ulimit of 10000) | | modules | C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-= project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hado= op-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-ya= rn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-projec= t/hadoop-yarn/hadoop-yarn-client hadoop-mapreduce-project/hadoop-mapreduce-= client/hadoop-mapreduce-client-jobclient U: . | | Console output | https://builds.apache.org/job/PreCommit-YARN-Build/20579= /console | | Powered by | Apache Yetus 0.8.0-SNAPSHOT http://yetus.apache.org | This message was automatically generated. > Revisit NodeAttribute class structure > ------------------------------------- > > Key: YARN-7892 > URL: https://issues.apache.org/jira/browse/YARN-7892 > Project: Hadoop YARN > Issue Type: Sub-task > Components: resourcemanager > Reporter: Naganarasimha G R > Assignee: Naganarasimha G R > Priority: Major > Attachments: YARN-7892-YARN-3409.001.patch, YARN-7892-YARN-3409.0= 02.patch, YARN-7892-YARN-3409.003.WIP.patch, YARN-7892-YARN-3409.003.patch,= YARN-7892-YARN-3409.004.patch, YARN-7892-YARN-3409.005.patch > > > In the existing structure, we had kept the type and value along with the = attribute which would create confusion to the user to understand the APIs a= s they would not be clear as to what needs to be sent for type and value wh= ile fetching the mappings for node(s). > As well as equals will not make sense when we compare only for prefix and= name where as values for them might be different.=C2=A0=C2=A0 -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: yarn-issues-help@hadoop.apache.org