hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Íñigo Goiri (JIRA) <j...@apache.org>
Subject [jira] [Commented] (YARN-8336) Fix potential connection leak in SchedConfCLI and YarnWebServiceUtils
Date Wed, 23 May 2018 16:44:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-8336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16487610#comment-16487610
] 

Íñigo Goiri commented on YARN-8336:
-----------------------------------

Same fix as YARN-8334; LGTM.
Is there any unit test covering this code path?

The only concern is the inconsistency to check the OK status between these two pieces of code.
We may want to open a JIRA to make the WS management consistent in the YARN Router.


> Fix potential connection leak in SchedConfCLI and YarnWebServiceUtils
> ---------------------------------------------------------------------
>
>                 Key: YARN-8336
>                 URL: https://issues.apache.org/jira/browse/YARN-8336
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Giovanni Matteo Fumarola
>            Assignee: Giovanni Matteo Fumarola
>            Priority: Major
>         Attachments: YARN-8336.v1.patch, YARN-8336.v2.patch
>
>
> Missing ClientResponse.close and Client.destroy can lead to a connection leak.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message