hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anbang Hu (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (YARN-8327) Fix TestAggregatedLogFormat#testReadAcontainerLogs1 on Windows
Date Sat, 19 May 2018 01:55:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-8327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16481416#comment-16481416
] 

Anbang Hu edited comment on YARN-8327 at 5/19/18 1:54 AM:
----------------------------------------------------------

Thanks [~giovanni.fumarola] for providing [^YARN-8327.v1.patch]. I think the picture you
showed for "Before the patch" is not the correct one.

I see the following when I debug the test:

!image-2018-05-18-18-50-04-288.png!

Although it's just counting characters, it would still make more sense to have {{System.lineSeparator()}}
twice in the end. Can you confirm line separator appears twice on Linux as well? By the way,
do we know why it is {{\n}} before "End of Log"?


was (Author: huanbang1993):
Thanks [~giovanni.fumarola] for providing [^YARN-8327.v1.patch]. I think the picture you
showed for "Before the patch" is not the correct one.

I see the following when I debug the test:

!image-2018-05-18-18-50-04-288.png!

Although it's just counting characters, it would still make more sense to have \{System.lineSeparator()}
twice in the end. Can you confirm line separator appears twice on Linux as well? By the way,
do we know why it is \{\n} before "End of Log"?

> Fix TestAggregatedLogFormat#testReadAcontainerLogs1 on Windows
> --------------------------------------------------------------
>
>                 Key: YARN-8327
>                 URL: https://issues.apache.org/jira/browse/YARN-8327
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: log-aggregation
>            Reporter: Giovanni Matteo Fumarola
>            Assignee: Giovanni Matteo Fumarola
>            Priority: Major
>         Attachments: YARN-8327.v1.patch, image-2018-05-18-16-51-47-324.png, image-2018-05-18-16-52-08-250.png
>
>
> TestAggregatedLogFormat#testReadAcontainerLogs1 fails on Windows because of the line
separator.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message