hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shane Kumpf (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-8209) NPE in DeletionService
Date Wed, 02 May 2018 15:48:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-8209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16461207#comment-16461207
] 

Shane Kumpf commented on YARN-8209:
-----------------------------------

Thanks for the patch, [~ebadger]! I tested the 004 patch and it fixes the issue. It would
be good to address the findbugs and checkstyle issues here. The rest of the comments could
be deferred until the follow on patch if needed. The failed test seems unrelated.
 # javadoc is missing for {{DockerCommand#preparePrivilegedOperation}}
 # The formatting change in {{DockerCommandExecutor#executeDockerCommand}} doesn't look to
be necessary.
 # Only {{DockerInspectCommand#getContainerStatus}} is addressed for {{docker inspect}}, is
the plan to handle {{DockerInspectCommand#getIpAndHost}} in the follow on? It would be good
to have consistency for a given docker command.
 # I'm not sure if the {{containerId}} field is needed in {{DockerInspectCommand}} or {{DockerRmCommand}},
{{containerName}} seems like it would still be sufficient. Getting rid of it would also fix
the findbugs warning.

> NPE in DeletionService
> ----------------------
>
>                 Key: YARN-8209
>                 URL: https://issues.apache.org/jira/browse/YARN-8209
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Chandni Singh
>            Assignee: Eric Badger
>            Priority: Critical
>         Attachments: YARN-8209.001.patch, YARN-8209.002.patch, YARN-8209.003.patch, YARN-8209.004.patch
>
>
> {code:java}
> 2018-04-25 23:38:41,039 WARN  concurrent.ExecutorHelper (ExecutorHelper.java:logThrowableFromAfterExecute(63))
- Caught exception in thread DeletionService #1:
> java.lang.NullPointerException
>         at org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.runtime.docker.DockerClient.writeCommandToTempFile(DockerClient.java:109)
>         at org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.runtime.docker.DockerCommandExecutor.executeDockerCommand(DockerCommandExecutor.java:85)
>         at org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.runtime.docker.DockerCommandExecutor.executeStatusCommand(DockerCommandExecutor.java:192)
>         at org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.runtime.docker.DockerCommandExecutor.getContainerStatus(DockerCommandExecutor.java:128)
>         at org.apache.hadoop.yarn.server.nodemanager.LinuxContainerExecutor.removeDockerContainer(LinuxContainerExecutor.java:935)
>         at org.apache.hadoop.yarn.server.nodemanager.containermanager.deletion.task.DockerContainerDeletionTask.run(DockerContainerDeletionTask.java:61)
>         at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
>         at java.util.concurrent.FutureTask.run(FutureTask.java:266)
>         at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180)
>         at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293)
>         at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
>         at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
>         at java.lang.Thread.run(Thread.java:748){code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message