hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eric Yang (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (YARN-8207) Docker container launch use popen have risk of shell expansion
Date Mon, 07 May 2018 21:48:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-8207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16466512#comment-16466512
] 

Eric Yang edited comment on YARN-8207 at 5/7/18 9:47 PM:
---------------------------------------------------------

[~jlowe] Hadoop 3.1.1 release date was proposed for May 7th.  This is a blocking issue for
YARN-7654.  I think this JIRA is very close to completion, and I like to make sure that we
can catch the release train.  Are you comfortable with the latest iteration of this patch?


was (Author: eyang):
[~jlowe] Hadoop 3.1.1 release date was proposed for May 7th.  This is a blocking issue for
YARN-7654.  I think this JIRA is very close to completion, and I like to make sure that we
can catch the release train.  Are you comfortable to the last iteration of this patch?

> Docker container launch use popen have risk of shell expansion
> --------------------------------------------------------------
>
>                 Key: YARN-8207
>                 URL: https://issues.apache.org/jira/browse/YARN-8207
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: yarn-native-services
>    Affects Versions: 3.0.0, 3.1.0, 3.0.1, 3.0.2
>            Reporter: Eric Yang
>            Assignee: Eric Yang
>            Priority: Blocker
>              Labels: Docker
>         Attachments: YARN-8207.001.patch, YARN-8207.002.patch, YARN-8207.003.patch, YARN-8207.004.patch,
YARN-8207.005.patch, YARN-8207.006.patch, YARN-8207.007.patch
>
>
> Container-executor code utilize a string buffer to construct docker run command, and
pass the string buffer to popen for execution.  Popen spawn a shell to run the command.  Some
arguments for docker run are still vulnerable to shell expansion.  The possible solution is
to convert from char * buffer to string array for execv to avoid shell expansion.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message