hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Naganarasimha G R (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-7892) Revisit NodeAttribute class structure
Date Thu, 03 May 2018 12:01:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-7892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16462334#comment-16462334
] 

Naganarasimha G R commented on YARN-7892:
-----------------------------------------

Hi [~bibinchundatt],

     Hope you could specify comments refers which classes else its kind of difficult which
part of the code you are referring .
 # not sure which class you are referring to can you provide more information 
 # nice catch as default is set i think we can remove from 60 to 62 ?
 # i think you are referring to NodeAttributesManagerImpl, if so i think current code is creating
a new collection so the backend structure does not get impacted. So do we really need to a
make unmodifiable collection ?
 # Can you more specifc which class requires java docs changes (i can see it requires for NodeAttributesManager.getAttributesToNodes)
any thing else you have in your mind.
 # Hope you are referred to the latest patch as i had tested that in local machine and seems
to be working fine. 

> Revisit NodeAttribute class structure
> -------------------------------------
>
>                 Key: YARN-7892
>                 URL: https://issues.apache.org/jira/browse/YARN-7892
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Naganarasimha G R
>            Assignee: Naganarasimha G R
>            Priority: Major
>         Attachments: YARN-7892-YARN-3409.001.patch, YARN-7892-YARN-3409.002.patch, YARN-7892-YARN-3409.003.WIP.patch,
YARN-7892-YARN-3409.003.patch, YARN-7892-YARN-3409.004.patch, YARN-7892-YARN-3409.005.patch
>
>
> In the existing structure, we had kept the type and value along with the attribute which
would create confusion to the user to understand the APIs as they would not be clear as to
what needs to be sent for type and value while fetching the mappings for node(s).
> As well as equals will not make sense when we compare only for prefix and name where
as values for them might be different.  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message