From yarn-issues-return-143460-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Thu Apr 26 18:45:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 26A3B180679 for ; Thu, 26 Apr 2018 18:45:04 +0200 (CEST) Received: (qmail 25743 invoked by uid 500); 26 Apr 2018 16:45:04 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 25732 invoked by uid 99); 26 Apr 2018 16:45:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 26 Apr 2018 16:45:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id BA9BD1A277F for ; Thu, 26 Apr 2018 16:45:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -101.511 X-Spam-Level: X-Spam-Status: No, score=-101.511 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id LcfrrqwLJiZk for ; Thu, 26 Apr 2018 16:45:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 7D90A5F11F for ; Thu, 26 Apr 2018 16:45:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id E4782E010F for ; Thu, 26 Apr 2018 16:45:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id AC4B421094 for ; Thu, 26 Apr 2018 16:45:00 +0000 (UTC) Date: Thu, 26 Apr 2018 16:45:00 +0000 (UTC) From: "genericqa (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-8202) DefaultAMSProcessor should properly check units of requested custom resource types against minimum/maximum allocation MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-8202?page=3Dcom.atlassian.= jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16454= 521#comment-16454521 ]=20 genericqa commented on YARN-8202: --------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 43s= {color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0= m 0s{color} | {color:green} The patch does not contain any @author tags. {= color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green}= 0m 0s{color} | {color:green} The patch appears to include 5 new or modif= ied test files. {color} | || || || || {color:brown} trunk Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 20s= {color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}= 25m 29s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 30= m 24s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}= 3m 17s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 3= m 53s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:gree= n} 18m 13s{color} | {color:green} branch has no errors when building and te= sting our client artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} = 7m 17s{color} | {color:green} trunk passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3= m 48s{color} | {color:green} trunk passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 26s= {color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}= 3m 52s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 39= m 47s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 39m = 47s{color} | {color:green} the patch passed {color} | | {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:oran= ge} 3m 37s{color} | {color:orange} root: The patch generated 43 new + 164 = unchanged - 53 fixed =3D 207 total (was 217) {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 4= m 58s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m = 0s{color} | {color:red} The patch has 3 line(s) that end in whitespace. Use= git apply --whitespace=3Dfix <>. Refer https://git-scm.com/doc= s/git-apply {color} | | {color:green}+1{color} | {color:green} shadedclient {color} | {color:gree= n} 12m 21s{color} | {color:green} patch has no errors when building and tes= ting our client artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} = 8m 22s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 4= m 0s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m = 5s{color} | {color:green} hadoop-yarn-api in the patch passed. {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 3m 48s{col= or} | {color:red} hadoop-yarn-common in the patch failed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 4= 4s{color} | {color:green} hadoop-yarn-server-common in the patch passed. {c= olor} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 68m 4= 3s{color} | {color:green} hadoop-yarn-server-resourcemanager in the patch p= assed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 9m 1= 0s{color} | {color:green} hadoop-mapreduce-client-app in the patch passed. = {color} | | {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m 3= 8s{color} | {color:red} The patch generated 2 ASF License warnings. {color}= | | {color:black}{color} | {color:black} {color} | {color:black}253m 20s{colo= r} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | hadoop.yarn.api.resource.TestPlacementConstraintTran= sformations | \\ \\ || Subsystem || Report/Notes || | Docker | Client=3D17.05.0-ce Server=3D17.05.0-ce Image:yetus/hadoop:b78c9= 4f | | JIRA Issue | YARN-8202 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/1292078= 6/YARN-8202-003.patch | | Optional Tests | asflicense compile javac javadoc mvninstall mvnsit= e unit shadedclient findbugs checkstyle | | uname | Linux 15004610a5d3 3.13.0-139-generic #188-Ubuntu SMP Tue Jan 9 1= 4:43:09 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | trunk / af986b4 | | maven | version: Apache Maven 3.3.9 | | Default Java | 1.8.0_162 | | findbugs | v3.1.0-RC1 | | checkstyle | https://builds.apache.org/job/PreCommit-YARN-Build/20487/art= ifact/out/diff-checkstyle-root.txt | | whitespace | https://builds.apache.org/job/PreCommit-YARN-Build/20487/art= ifact/out/whitespace-eol.txt | | unit | https://builds.apache.org/job/PreCommit-YARN-Build/20487/artifact/= out/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common.txt | | Test Results | https://builds.apache.org/job/PreCommit-YARN-Build/20487/= testReport/ | | asflicense | https://builds.apache.org/job/PreCommit-YARN-Build/20487/art= ifact/out/patch-asflicense-problems.txt | | Max. process+thread count | 815 (vs. ulimit of 10000) | | modules | C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-= project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hado= op-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/ha= doop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-mapreduce-projec= t/hadoop-mapreduce-client/hadoop-mapreduce-client-app U: . | | Console output | https://builds.apache.org/job/PreCommit-YARN-Build/20487= /console | | Powered by | Apache Yetus 0.8.0-SNAPSHOT http://yetus.apache.org | This message was automatically generated. > DefaultAMSProcessor should properly check units of requested custom resou= rce types against minimum/maximum allocation > -------------------------------------------------------------------------= -------------------------------------------- > > Key: YARN-8202 > URL: https://issues.apache.org/jira/browse/YARN-8202 > Project: Hadoop YARN > Issue Type: Bug > Reporter: Szilard Nemeth > Assignee: Szilard Nemeth > Priority: Blocker > Attachments: YARN-8202-001.patch, YARN-8202-002.patch, YARN-8202-= 003.patch, YARN-8202-004.patch > > > =C2=A0 > When I execute a pi job with arguments:=C2=A0 > {code:java} > -Dmapreduce.map.resource.memory-mb=3D200 -Dmapreduce.map.resource.resourc= e1=3D500M 1 1000{code} > and I have one node with 5GB of resource1, I get the following exception = on every second and the job hangs: > {code:java} > 2018-04-24 08:42:03,694 INFO org.apache.hadoop.ipc.Server: IPC Server han= dler 20 on 8030, call Call#386 Retry#0 org.apache.hadoop.yarn.api.Applicati= onMasterProtocolPB.allocate from 172.31.119.172:58138 > org.apache.hadoop.yarn.exceptions.InvalidResourceRequestException: Invali= d resource request, requested resource type=3D[resource1] < 0 or greater th= an maximum allowed allocation. Requested resource=3D, maximum allowed allocation=3D, please note that maximum allowed allocation is calculated by sc= heduler based on maximum resource of registered NodeManagers, which might b= e less than configured maximum allocation=3D > =C2=A0 =C2=A0 =C2=A0 =C2=A0 at org.apache.hadoop.yarn.server.resourcemana= ger.scheduler.SchedulerUtils.validateResourceRequest(SchedulerUtils.java:28= 6) > =C2=A0 =C2=A0 =C2=A0 =C2=A0 at org.apache.hadoop.yarn.server.resourcemana= ger.scheduler.SchedulerUtils.normalizeAndValidateRequest(SchedulerUtils.jav= a:242) > =C2=A0 =C2=A0 =C2=A0 =C2=A0 at org.apache.hadoop.yarn.server.resourcemana= ger.scheduler.SchedulerUtils.normalizeAndvalidateRequest(SchedulerUtils.jav= a:258) > =C2=A0 =C2=A0 =C2=A0 =C2=A0 at org.apache.hadoop.yarn.server.resourcemana= ger.RMServerUtils.normalizeAndValidateRequests(RMServerUtils.java:249) > =C2=A0 =C2=A0 =C2=A0 =C2=A0 at org.apache.hadoop.yarn.server.resourcemana= ger.DefaultAMSProcessor.allocate(DefaultAMSProcessor.java:230) > =C2=A0 =C2=A0 =C2=A0 =C2=A0 at org.apache.hadoop.yarn.server.resourcemana= ger.scheduler.constraint.processor.DisabledPlacementProcessor.allocate(Disa= bledPlacementProcessor.java:75) > =C2=A0 =C2=A0 =C2=A0 =C2=A0 at org.apache.hadoop.yarn.server.resourcemana= ger.AMSProcessingChain.allocate(AMSProcessingChain.java:92) > =C2=A0 =C2=A0 =C2=A0 =C2=A0 at org.apache.hadoop.yarn.server.resourcemana= ger.ApplicationMasterService.allocate(ApplicationMasterService.java:433) > =C2=A0 =C2=A0 =C2=A0 =C2=A0 at org.apache.hadoop.yarn.api.impl.pb.service= .ApplicationMasterProtocolPBServiceImpl.allocate(ApplicationMasterProtocolP= BServiceImpl.java:60) > =C2=A0 =C2=A0 =C2=A0 =C2=A0 at org.apache.hadoop.yarn.proto.ApplicationMa= sterProtocol$ApplicationMasterProtocolService$2.callBlockingMethod(Applicat= ionMasterProtocol.java:99) > =C2=A0 =C2=A0 =C2=A0 =C2=A0 at org.apache.hadoop.ipc.ProtobufRpcEngine$Se= rver$ProtoBufRpcInvoker.call(ProtobufRpcEngine.java:523) > =C2=A0 =C2=A0 =C2=A0 =C2=A0 at org.apache.hadoop.ipc.RPC$Server.call(RPC.= java:991) > =C2=A0 =C2=A0 =C2=A0 =C2=A0 at org.apache.hadoop.ipc.Server$RpcCall.run(S= erver.java:872) > =C2=A0 =C2=A0 =C2=A0 =C2=A0 at org.apache.hadoop.ipc.Server$RpcCall.run(S= erver.java:818) > =C2=A0 =C2=A0 =C2=A0 =C2=A0 at java.security.AccessController.doPrivilege= d(Native Method) > =C2=A0 =C2=A0 =C2=A0 =C2=A0 at javax.security.auth.Subject.doAs(Subject.j= ava:422) > =C2=A0 =C2=A0 =C2=A0 =C2=A0 at org.apache.hadoop.security.UserGroupInform= ation.doAs(UserGroupInformation.java:1682) > =C2=A0 =C2=A0 =C2=A0 =C2=A0 at org.apache.hadoop.ipc.Server$Handler.run(S= erver.java:2678) > {code} > *This is because=C2=A0org.apache.hadoop.yarn.server.resourcemanager.sched= uler.SchedulerUtils#validateResourceRequest does not take resource units in= to account.* > =C2=A0 > However, if I start a job with arguments:=C2=A0 > {code:java} > -Dmapreduce.map.resource.memory-mb=3D200 -Dmapreduce.map.resource.resourc= e1=3D1G 1 1000{code} > and I still have 5GB of resource1 on one node then the job runs successfu= lly. > =C2=A0 > I also tried a third=C2=A0job run, when I request 1GB of resource1 and I = have no nodes with any amount of resource1, then I restart the node with 5G= Bs of resource1, the job ultimately completes, but just after the node with= enough resources registered in RM, which is the desired behaviour. > =C2=A0 -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: yarn-issues-help@hadoop.apache.org