From yarn-issues-return-142002-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Tue Apr 10 17:06:06 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id C234818064C for ; Tue, 10 Apr 2018 17:06:05 +0200 (CEST) Received: (qmail 45915 invoked by uid 500); 10 Apr 2018 15:06:04 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 45803 invoked by uid 99); 10 Apr 2018 15:06:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 10 Apr 2018 15:06:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 3F63A18028B for ; Tue, 10 Apr 2018 15:06:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.311 X-Spam-Level: X-Spam-Status: No, score=-110.311 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id KOqf7pID60b1 for ; Tue, 10 Apr 2018 15:06:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 3475F5FBB0 for ; Tue, 10 Apr 2018 15:06:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id D9204E0BC7 for ; Tue, 10 Apr 2018 15:06:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 63E35241D0 for ; Tue, 10 Apr 2018 15:06:00 +0000 (UTC) Date: Tue, 10 Apr 2018 15:06:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-8057) Inadequate information for handling catch clauses MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-8057?page=3Dcom.atlassian.= jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16432= 420#comment-16432420 ]=20 ASF GitHub Bot commented on YARN-8057: -------------------------------------- GitHub user lzh3636 opened a pull request: https://github.com/apache/hadoop/pull/362 YARN-8057 Inadequate information for handling catch clauses The description of the problem: https://issues.apache.org/jira/browse/YARN-8057 I added stack traces information to those two logging statements, so th= at the full exception information can be generated to the logs. You can merge this pull request into a Git repository by running: $ git pull https://github.com/lzh3636/hadoop YARN-8057 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/hadoop/pull/362.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #362 =20 ---- commit 002935625784226ba915e8631a0c8298d423677f Author: lzh3636 Date: 2018-04-10T15:03:54Z update stack traces to show exception info ---- > Inadequate information for handling catch clauses > ------------------------------------------------- > > Key: YARN-8057 > URL: https://issues.apache.org/jira/browse/YARN-8057 > Project: Hadoop YARN > Issue Type: Improvement > Components: api, yarn > Affects Versions: 3.0.0 > Reporter: Zhenhao Li > Priority: Major > Labels: easyfix > > Their are some situations that different exception types are caught, but = the handling of those exceptions can not show the differences of those type= s. Here are the code snippets we found which have this problem: > *org/apache/hadoop/yarn/client/api/impl/NMClientImpl.java* > [https://github.com/apache/hadoop/blob/c02d2ba50db8a355ea03081c3984b2ea0c= 375a3f/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org= /apache/hadoop/yarn/client/api/impl/NMClientImpl.java] > At Line=C2=A0*125* and Line *129.*=C2=A0We can see that two exception typ= es are caught, but the logging statements here can not show the exception t= ype at all. It may cause confusions to the person who=C2=A0is reading the l= og, the person can not know what exception happened here. > =C2=A0 > Maybe adding stack trace information to these two logging statements is a= simple way to improve it. > =C2=A0 -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: yarn-issues-help@hadoop.apache.org