hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Lowe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-7189) Container-executor doesn't remove Docker containers that error out early
Date Thu, 12 Apr 2018 22:03:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-7189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16436358#comment-16436358
] 

Jason Lowe commented on YARN-7189:
----------------------------------

Thanks for updating the patch!  I agree this looks difficult to unit test directly.

When pclose does not return 0 we cannot blindly assume errno is set.  It is only set when
pclose returns -1.  Otherwise it returns the exit status which could just be a non-zero exit
code from docker.  That also reminds me that we technically should be using the WIFEXITED
and WEXITSTATUS macros to examine the resulting status when it isn't -1 to look for a successful
exit from the subcommand.

Nit: it would be nice to be consistent about the spacing between the {{if}} and the parentheses.




> Container-executor doesn't remove Docker containers that error out early
> ------------------------------------------------------------------------
>
>                 Key: YARN-7189
>                 URL: https://issues.apache.org/jira/browse/YARN-7189
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: yarn
>    Affects Versions: 2.9.0, 2.8.3, 3.0.1
>            Reporter: Eric Badger
>            Assignee: Eric Badger
>            Priority: Major
>         Attachments: YARN-7189-b3.0.001.patch, YARN-7189-branch-3.0.001.patch, YARN-7189-branch-3.0.002.patch
>
>
> Once the docker run command is executed, the docker container is created unless the return
code is 125 meaning that the run command itself failed (https://docs.docker.com/engine/reference/run/#exit-status).
Any error that happens after the docker run needs to remove the container during cleanup.
> {noformat:title=container-executor.c:launch_docker_container_as_user}
>   snprintf(docker_command_with_binary, command_size, "%s %s", docker_binary, docker_command);
>   fprintf(LOGFILE, "Launching docker container...\n");
>   FILE* start_docker = popen(docker_command_with_binary, "r");
> {noformat}
> This is fixed by YARN-5366, which changes how we remove containers. However, that was
committed into 3.1.0. 2.8, 2.9, and 3.0 are all affected



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message