From yarn-issues-return-141158-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Fri Mar 30 18:41:03 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 446CE180647 for ; Fri, 30 Mar 2018 18:41:03 +0200 (CEST) Received: (qmail 75805 invoked by uid 500); 30 Mar 2018 16:41:02 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 75791 invoked by uid 99); 30 Mar 2018 16:41:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 30 Mar 2018 16:41:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id D62A1C0042 for ; Fri, 30 Mar 2018 16:41:01 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id c8F2_0HesNyg for ; Fri, 30 Mar 2018 16:41:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id CD94F5F18F for ; Fri, 30 Mar 2018 16:41:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 5611FE0D6A for ; Fri, 30 Mar 2018 16:41:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 14A37255F9 for ; Fri, 30 Mar 2018 16:41:00 +0000 (UTC) Date: Fri, 30 Mar 2018 16:41:00 +0000 (UTC) From: =?utf-8?Q?=C3=8D=C3=B1igo_Goiri_=28JIRA=29?= To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Assigned] (YARN-8096) Wrong condition in AmIpFilter#getProxyAddresses() to update the proxy IP list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-8096?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:all-tabpanel ] =C3=8D=C3=B1igo Goiri reassigned YARN-8096: --------------------------------- Assignee: Oleksandr Shevchenko > Wrong condition in AmIpFilter#getProxyAddresses() to update the proxy IP = list > -------------------------------------------------------------------------= ---- > > Key: YARN-8096 > URL: https://issues.apache.org/jira/browse/YARN-8096 > Project: Hadoop YARN > Issue Type: Bug > Affects Versions: 3.0.0 > Reporter: Oleksandr Shevchenko > Assignee: Oleksandr Shevchenko > Priority: Major > Attachments: YARN-8096.001.patch > > > In AmIpFilter#getProxyAddresses() we have the following condition: > {code:java} > if (proxyAddresses =3D=3D null || (lastUpdate + UPDATE_INTERVAL) >=3D no= w) {=20 > //update RM address=20 > } > {code} > By design, the address should be updated if the last update was more then= 5 min ago. But as we see this condition is wrong. > Currently, RM address updates permanently. But after 5 minutes after the = last update, RM address will never be updated again. As a result, we are al= ways redirected to the fail page that was added by YARN-4767, even if a net= work issue is resolved now. > So, we should change this condition to: > {code:java} > if (proxyAddresses =3D=3D null || (lastUpdate + UPDATE_INTERVAL) <=3D no= w) \{=20 > //update RM address=20 > } > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: yarn-issues-help@hadoop.apache.org