From yarn-issues-return-140005-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Sun Mar 18 16:38:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 8E748180645 for ; Sun, 18 Mar 2018 16:38:04 +0100 (CET) Received: (qmail 76871 invoked by uid 500); 18 Mar 2018 15:38:03 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 76860 invoked by uid 99); 18 Mar 2018 15:38:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 18 Mar 2018 15:38:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id E92C3C0115 for ; Sun, 18 Mar 2018 15:38:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.311 X-Spam-Level: X-Spam-Status: No, score=-110.311 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id hib2Ezo3Pc0Q for ; Sun, 18 Mar 2018 15:38:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 34C735F635 for ; Sun, 18 Mar 2018 15:38:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 5CF34E0181 for ; Sun, 18 Mar 2018 15:38:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 0862921290 for ; Sun, 18 Mar 2018 15:38:00 +0000 (UTC) Date: Sun, 18 Mar 2018 15:38:00 +0000 (UTC) From: "Wangda Tan (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (YARN-8046) Revisit RMWebServiceProtocol implementations MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-8046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wangda Tan updated YARN-8046: ----------------------------- Description: I recently found that new changes of RMWebServiceProtocol make adding any new REST API is pretty hard. There're at least 6 classes need to be implemented: 1. {{MockRESTRequestInterceptor}} 2. {{FederationInterceptorREST}} 3. {{DefaultRequestInterceptorREST}} 4. {{PassThroughRESTRequestInterceptor} 5. {{RouterWebServices}} 6. {{RMWebServices}} Different classes implementations have different styles, simple copy-paste is not enough. For example. {{DefaultRequestInterceptorREST}} uses {{RouterWebServiceUtil.genericForward}} to pass all parameters, which needs to understand how each REST API works, reconstruct an URL which can easily cause issues. I think we should revisit these APIs and make sure new API can be easier added to REST interface like before. was: I recently found that new changes of RMWebServiceProtocol make adding any new REST API pretty hard. There're at least 6 classes need to be implemented: 1. {{MockRESTRequestInterceptor}} 2. {{FederationInterceptorREST}} 3. {{DefaultRequestInterceptorREST}} 4. {{PassThroughRESTRequestInterceptor} 5. {{RouterWebServices}} 6. {{RMWebServices}} Different classes implementations have different styles, simple copy-paste is not enough. For example. {{DefaultRequestInterceptorREST}} uses {{RouterWebServiceUtil.genericForward}} to pass all parameters, which needs to understand how each REST API works, reconstruct an URL which can easily cause issues. I think we should revisit these APIs and make sure new API can be easier added to REST interface like before. > Revisit RMWebServiceProtocol implementations > -------------------------------------------- > > Key: YARN-8046 > URL: https://issues.apache.org/jira/browse/YARN-8046 > Project: Hadoop YARN > Issue Type: Improvement > Reporter: Wangda Tan > Priority: Critical > > I recently found that new changes of RMWebServiceProtocol make adding any new REST API is pretty hard. There're at least 6 classes need to be implemented: > 1. {{MockRESTRequestInterceptor}} > 2. {{FederationInterceptorREST}} > 3. {{DefaultRequestInterceptorREST}} > 4. {{PassThroughRESTRequestInterceptor} > 5. {{RouterWebServices}} > 6. {{RMWebServices}} > Different classes implementations have different styles, simple copy-paste is not enough. For example. > {{DefaultRequestInterceptorREST}} uses {{RouterWebServiceUtil.genericForward}} to pass all parameters, which needs to understand how each REST API works, reconstruct an URL which can easily cause issues. > I think we should revisit these APIs and make sure new API can be easier added to REST interface like before. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: yarn-issues-help@hadoop.apache.org