From yarn-issues-return-139553-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Sat Mar 10 11:52:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 56BAE180651 for ; Sat, 10 Mar 2018 11:52:05 +0100 (CET) Received: (qmail 88761 invoked by uid 500); 10 Mar 2018 10:52:04 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 88750 invoked by uid 99); 10 Mar 2018 10:52:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 10 Mar 2018 10:52:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id AA4D2C005C for ; Sat, 10 Mar 2018 10:52:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.311 X-Spam-Level: X-Spam-Status: No, score=-110.311 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id Cv-8OjxYBnQq for ; Sat, 10 Mar 2018 10:52:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 372285F56D for ; Sat, 10 Mar 2018 10:52:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 05003E0CDA for ; Sat, 10 Mar 2018 10:52:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 48DBE21457 for ; Sat, 10 Mar 2018 10:52:00 +0000 (UTC) Date: Sat, 10 Mar 2018 10:52:00 +0000 (UTC) From: "Weiwei Yang (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-8002) Support NOT_SELF and ALL namespace types for allocation tag MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-8002?page=3Dcom.atlassian.= jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16394= 128#comment-16394128 ]=20 Weiwei Yang commented on YARN-8002: ----------------------------------- Hi [~leftnoteasy] Thanks for the comments. Since #4 is going to result a major change, let me= reply first {quote}About existing aggregation approach {quote} The approach in this patch adds the flexibility to let it easy to get cardi= nality on +a set of application IDs+ regardless what namespace it is. The e= xtra computation will only happen when we need to compute PC against app-ta= g (or other namespace that evals to a set of app IDs), not every time. And = with the extra cost you mentioned (which I don't think it is very bad). Wha= t you suggested saves this cost, but it will be hard to support +not-self, = app-ids(a set of IDs) or possibly app-regex+ etc. I'd like to hold on re-im= plementing this until every one agrees we are not going to=C2=A0support tho= se. Regarding rest of comments {quote}So how about calling it like "AllocationTagsFilter" or "AllocationTa= gsQuery"? {quote} Hmm, if you look at the class, it contains 2 fields, one is {{AllocationTag= Namespace}} and the other is a set of allocation tags. This is naturally re= presenting multiple allocation tags within one same namespace. If you think= this name is confusing, how about {{AllocationTagsWithNamespace}}? But I p= refer the current name. {quote}About ALL evaluator: {quote} Agree. Even in current patch, it checks if the namespace is ALL and directl= y retrieve from global mapping if it is. So eval on ALL is not necessary. I= can simply replace that with a no OPT. {quote}I'm not sure if NOT_SELF is necessary, unless it is must-to-have, I = don't suggest to add it. {quote} I am OK with removing it, I am holding it for now in case [~asuresh] might = give his opinion. {quote}we should keep as less public interfaces as possible for ATM {quote} Agree. Even I was planing to remove them, I did not include that in this pa= tch was trying to minimize the changes for easier review. I will address th= at in next patch. Thanks. > Support NOT_SELF and ALL namespace types for allocation tag > ----------------------------------------------------------- > > Key: YARN-8002 > URL: https://issues.apache.org/jira/browse/YARN-8002 > Project: Hadoop YARN > Issue Type: Sub-task > Components: resourcemanager > Reporter: Weiwei Yang > Assignee: Weiwei Yang > Priority: Major > Attachments: YARN-8002.001.patch, YARN-8002.002.patch > > > This is a continua task after YARN-7972, YARN-7972 adds support to specif= y=C2=A0tags with namespace SELF and APP_ID, like following > * self/ > * app-id// > this task is to track the work to support 2 of remaining namespace types = *NOT_SELF* & *ALL* (we'll support app-label later), > * not-self/ > * all/ > this will require a bit refactoring in {{AllocationTagsManager}} as it ne= eds to do some proper aggregation on tags for multiple apps. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: yarn-issues-help@hadoop.apache.org