From yarn-issues-return-139168-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Mon Mar 5 21:40:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 66887180676 for ; Mon, 5 Mar 2018 21:40:04 +0100 (CET) Received: (qmail 71034 invoked by uid 500); 5 Mar 2018 20:40:03 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 71019 invoked by uid 99); 5 Mar 2018 20:40:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 05 Mar 2018 20:40:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id B963BC0496 for ; Mon, 5 Mar 2018 20:40:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id vOiKiZgio3Rn for ; Mon, 5 Mar 2018 20:40:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id B1E685F504 for ; Mon, 5 Mar 2018 20:40:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id E62F9E0373 for ; Mon, 5 Mar 2018 20:40:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 4CE0F21273 for ; Mon, 5 Mar 2018 20:40:00 +0000 (UTC) Date: Mon, 5 Mar 2018 20:40:00 +0000 (UTC) From: "Miklos Szegedi (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-7626) Allow regular expression matching in container-executor.cfg for devices and named docker volumes mount MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-7626?page=3Dcom.atlassian.= jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16386= 738#comment-16386738 ]=20 Miklos Szegedi commented on YARN-7626: -------------------------------------- Thank you for the patch [~Zian Chen] and for the review [~leftnoteasy]. Optional: I have one style issue with the latest patch. When you refer to 6= in your patch like the one below, you should probably do sizeof("regex:").= This helps=C2=A0to better understand the code and it is more future proof. {code:java} 132=09return is_volume_name(requested) && (execute_regex_match(pattern + 6,= requested) =3D=3D 0);{code} > Allow regular expression matching in container-executor.cfg for devices a= nd named docker volumes mount > -------------------------------------------------------------------------= ----------------------------- > > Key: YARN-7626 > URL: https://issues.apache.org/jira/browse/YARN-7626 > Project: Hadoop YARN > Issue Type: New Feature > Reporter: Zian Chen > Assignee: Zian Chen > Priority: Major > Attachments: YARN-7626.001.patch, YARN-7626.002.patch, YARN-7626.= 003.patch, YARN-7626.004.patch, YARN-7626.005.patch, YARN-7626.006.patch, Y= ARN-7626.007.patch, YARN-7626.008.patch, YARN-7626.009.patch, YARN-7626.010= .patch > > > Currently when we config some of the GPU devices related fields (like ) i= n container-executor.cfg, these fields are generated based on different dri= ver versions or GPU device names. We want to enable regular expression matc= hing so that user don't need to manually set up these fields when config co= ntainer-executor.cfg, -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: yarn-issues-help@hadoop.apache.org