From yarn-issues-return-140009-apmail-hadoop-yarn-issues-archive=hadoop.apache.org@hadoop.apache.org Sun Mar 18 22:45:05 2018 Return-Path: X-Original-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-yarn-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E2EB8179E5 for ; Sun, 18 Mar 2018 22:45:05 +0000 (UTC) Received: (qmail 62024 invoked by uid 500); 18 Mar 2018 22:45:05 -0000 Delivered-To: apmail-hadoop-yarn-issues-archive@hadoop.apache.org Received: (qmail 61969 invoked by uid 500); 18 Mar 2018 22:45:05 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 61956 invoked by uid 99); 18 Mar 2018 22:45:05 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 18 Mar 2018 22:45:05 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id EFC2FC00CD for ; Sun, 18 Mar 2018 22:45:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id bSrkDB6fjlOG for ; Sun, 18 Mar 2018 22:45:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 3FE705F5FB for ; Sun, 18 Mar 2018 22:45:03 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 3F5B3E0D48 for ; Sun, 18 Mar 2018 22:45:02 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id D0053214A8 for ; Sun, 18 Mar 2018 22:45:00 +0000 (UTC) Date: Sun, 18 Mar 2018 22:45:00 +0000 (UTC) From: "Zian Chen (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-8016) Refine PlacementRule interface and add a app-name queue mapping rule as an example MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-8016?page=3Dcom.atlassian.= jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16404= 227#comment-16404227 ]=20 Zian Chen commented on YARN-8016: --------------------------------- ike Hi [~leftnoteasy] ,=C2=A0I just updated the refactored patch based on y= our previous suggestions. There are two questions I want to discuss the sec= ond patch, # The first question is to still put=C2=A0getQueueMappingEntity and setQue= ueMappingEntity inside=C2=A0CapacitySchedulerConfiguration, the reason has = mentioned in the above comments. # The second question is the test case for chain of placement rules. I und= erstand your suggestion is to like set up some cases which will let the swi= tch case condition inside CS#updatePlacementRules so that the case failed w= ith previous placement rule can still handle by the second placement rule, = for example, AppNamePlacementRule. However, the logic here is kind of stran= ge, if one case can enter into the first switch case which is UserGroupPlca= ementRule, then it means the mapping related to the case is for UserGroupMa= ppingRule, here in the switch case, we just initialize the rule based on th= e mapping, not doing the getPlacementForApp method call, so the condition= =C2=A0like we set user1 for the mapping but we actually use user2 to consum= e the mapping will not happen cause this is another story for=C2=A0getPlace= mentForApp related calls, not=C2=A0updatePlacementRules. Could you help check the second patch and give some comments on it, also th= e two questions I have above? Please let me know if you have any other thou= ghts and we can discuss further. Thank you! > Refine PlacementRule interface and add a app-name queue mapping rule as a= n example > -------------------------------------------------------------------------= --------- > > Key: YARN-8016 > URL: https://issues.apache.org/jira/browse/YARN-8016 > Project: Hadoop YARN > Issue Type: Task > Reporter: Zian Chen > Assignee: Zian Chen > Priority: Major > Attachments: YARN-8016.001.patch, YARN-8016.002.patch > > > After YARN-3635/YARN-6689, PlacementRule becomes a common interface which= can be used by scheduler and can be dynamically updated by scheduler accor= ding to configs. There're some other works.=20 > - There's no way to initialize PlacementRule. > - No example of PlacementRule except the user-group mapping one. > This JIRA is targeted to refine PlacementRule interfaces and add another = PlacementRule example. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: yarn-issues-help@hadoop.apache.org