hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Oleksandr Shevchenko (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-8096) Wrong condition in AmIpFilter#getProxyAddresses() to update the proxy IP list
Date Sat, 31 Mar 2018 06:45:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-8096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16421194#comment-16421194

Oleksandr Shevchenko commented on YARN-8096:

[~elgoiri] Thanks a lot for the review.
The next changes were added:
1. Removed check for the exception. I added it for more information in the case when test
2. Removed lambda. Please let me know if I should provide two patches with and without lambda
for different versions.
3. Removed destroy() the filter after the test.
4. Replaced hardcoded updateInterval time on TimeUnit.MINUTES.toMillis(5);
5. Renamed unknown host in the test.

Please review this changes.

> Wrong condition in AmIpFilter#getProxyAddresses() to update the proxy IP list
> -----------------------------------------------------------------------------
>                 Key: YARN-8096
>                 URL: https://issues.apache.org/jira/browse/YARN-8096
>             Project: Hadoop YARN
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: Oleksandr Shevchenko
>            Assignee: Oleksandr Shevchenko
>            Priority: Major
>         Attachments: YARN-8096.001.patch, YARN-8096.002.patch, YARN-8096.003.patch
> In AmIpFilter#getProxyAddresses() we have the following condition:
> {code:java}
>  if (proxyAddresses == null || (lastUpdate + UPDATE_INTERVAL) >= now) { 
>    //update RM address 
>  }
> {code}
> By design, the address should be updated if the last update was more then 5 min ago.
But as we see this condition is wrong.
> Currently, RM address updates permanently. But after 5 minutes after the last update,
RM address will never be updated again. As a result, we are always redirected to the fail
page that was added by YARN-4767, even if a network issue is resolved now.
> So, we should change this condition to:
> {code:java}
>  if (proxyAddresses == null || (lastUpdate + UPDATE_INTERVAL) <= now) \{ 
>    //update RM address 
>  }
> {code}

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org

View raw message