hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bibin A Chundatt (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-7988) Refactor FSNodeLabelStore code for attributes store support
Date Thu, 01 Mar 2018 16:41:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-7988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16382280#comment-16382280

Bibin A Chundatt commented on YARN-7988:

Thank you  [~cheersyang] for review
line 38, 44, 50, 63, 65: remove abstract
It seems you map a sub class of FSNodeStoreLogOp to an enum FSNodeLogOpCode, that seems to
be just for class initializing, is this required? Can it be replaced with simple factory method
without reflection code?
In my opinion addition of new LogOp definition become easy within this case. Any negative
you find with approach?
There seems to have chance to leak file descriptors, need to make sure close is wrapped in
finally clause, e.g AbstractFSNodeStore: line 126, line 160, line 177
try-with-resource is used now.
line 205, replace the deprecated cleanup method
During testcase debugging i did update timeout missed to revert the same.Handled in latest

> Refactor FSNodeLabelStore code for attributes store support
> -----------------------------------------------------------
>                 Key: YARN-7988
>                 URL: https://issues.apache.org/jira/browse/YARN-7988
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Bibin A Chundatt
>            Assignee: Bibin A Chundatt
>            Priority: Major
>         Attachments: YARN-7988-YARN-3409.002.patch, YARN-7988.001.patch
> # Abstract out file FileSystemStore operation
> # Define EditLog Operartions  and Mirror operation
> # Support compatibility with old nodelabel store

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org

View raw message