hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wilfred Spiegelenburg (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-7968) Reset the queue name in submission context while recovering an application
Date Wed, 07 Mar 2018 17:02:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-7968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16389794#comment-16389794
] 

Wilfred Spiegelenburg commented on YARN-7968:
---------------------------------------------

During recovery we only have the queue name in the submission context. That was why YARN-7139
was logged.
We currently restore the submission context from the statestore which already has the correct
queue set. We should not overwrite that with the one from the application object.
Do you mean that we should pull the queue out of the submission context and put it in the
application object on restore?

> Reset the queue name in submission context while recovering an application
> --------------------------------------------------------------------------
>
>                 Key: YARN-7968
>                 URL: https://issues.apache.org/jira/browse/YARN-7968
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: fairscheduler
>    Affects Versions: 3.1.0
>            Reporter: Yufei Gu
>            Assignee: Yufei Gu
>            Priority: Major
>
> After YARN-7139, the new application can get correct queue name in its submission context.
We need to do the same thing for application recovering. 
> {code}
>       if (isAppRecovering) {
>         if (LOG.isDebugEnabled()) {
>           LOG.debug(applicationId
>               + " is recovering. Skip notifying APP_ACCEPTED");
>         }
>       } else {
>         // During tests we do not always have an application object, handle
>         // it here but we probably should fix the tests
>         if (rmApp != null && rmApp.getApplicationSubmissionContext() != null)
{
>           // Before we send out the event that the app is accepted is
>           // to set the queue in the submissionContext (needed on restore etc)
>           rmApp.getApplicationSubmissionContext().setQueue(queue.getName());
>         }
>         rmContext.getDispatcher().getEventHandler().handle(
>             new RMAppEvent(applicationId, RMAppEventType.APP_ACCEPTED));
>       }
> {code}
> We can do it by moving the {{rmApp.getApplicationSubmissionContext().setQueue}} block
out of the if-else block. cc [~wilfreds].



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message