hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Miklos Szegedi (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-7626) Allow regular expression matching in container-executor.cfg for devices and named docker volumes mount
Date Mon, 05 Mar 2018 20:40:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-7626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16386738#comment-16386738
] 

Miklos Szegedi commented on YARN-7626:
--------------------------------------

Thank you for the patch [~Zian Chen] and for the review [~leftnoteasy].

Optional: I have one style issue with the latest patch. When you refer to 6 in your patch
like the one below, you should probably do sizeof("regex:"). This helpsĀ to better understand
the code and it is more future proof.
{code:java}
132	return is_volume_name(requested) && (execute_regex_match(pattern + 6, requested)
== 0);{code}

> Allow regular expression matching in container-executor.cfg for devices and named docker
volumes mount
> ------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-7626
>                 URL: https://issues.apache.org/jira/browse/YARN-7626
>             Project: Hadoop YARN
>          Issue Type: New Feature
>            Reporter: Zian Chen
>            Assignee: Zian Chen
>            Priority: Major
>         Attachments: YARN-7626.001.patch, YARN-7626.002.patch, YARN-7626.003.patch, YARN-7626.004.patch,
YARN-7626.005.patch, YARN-7626.006.patch, YARN-7626.007.patch, YARN-7626.008.patch, YARN-7626.009.patch,
YARN-7626.010.patch
>
>
> Currently when we config some of the GPU devices related fields (like ) in container-executor.cfg,
these fields are generated based on different driver versions or GPU device names. We want
to enable regular expression matching so that user don't need to manually set up these fields
when config container-executor.cfg,



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message