hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Akira Ajisaka (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-7576) Findbug warning for Resource exposing internal representation
Date Mon, 19 Mar 2018 00:56:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-7576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404263#comment-16404263
] 

Akira Ajisaka commented on YARN-7576:
-------------------------------------

+1 for the exclude change. Hi [~leftnoteasy], would you rebase the patch? 

> Findbug warning for Resource exposing internal representation
> -------------------------------------------------------------
>
>                 Key: YARN-7576
>                 URL: https://issues.apache.org/jira/browse/YARN-7576
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: api
>    Affects Versions: 3.0.0
>            Reporter: Jason Lowe
>            Assignee: Wangda Tan
>            Priority: Major
>         Attachments: YARN-7576.001.patch
>
>
> Precommit builds are complaining about a findbugs warning:
> {noformat}
> EI 	org.apache.hadoop.yarn.api.records.Resource.getResources() may expose internal representation
by returning Resource.resources
> 	
> Bug type EI_EXPOSE_REP (click for details)
> In class org.apache.hadoop.yarn.api.records.Resource
> In method org.apache.hadoop.yarn.api.records.Resource.getResources()
> Field org.apache.hadoop.yarn.api.records.Resource.resources
> At Resource.java:[line 213]
> Returning a reference to a mutable object value stored in one of the object's fields
exposes the internal representation of the object.  If instances are accessed by untrusted
code, and unchecked changes to the mutable object would compromise security or other important
properties, you will need to do something different. Returning a new copy of the object is
better approach in many situations.
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message