From yarn-issues-return-137250-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Mon Feb 5 11:58:08 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id C25BE180647 for ; Mon, 5 Feb 2018 11:58:08 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id B240D160C4B; Mon, 5 Feb 2018 10:58:08 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 07A5B160C46 for ; Mon, 5 Feb 2018 11:58:07 +0100 (CET) Received: (qmail 57224 invoked by uid 500); 5 Feb 2018 10:58:07 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 57213 invoked by uid 99); 5 Feb 2018 10:58:07 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 05 Feb 2018 10:58:07 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 8C8A0180376 for ; Mon, 5 Feb 2018 10:58:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id uZAA24-JSahP for ; Mon, 5 Feb 2018 10:58:05 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 5975E5F5FB for ; Mon, 5 Feb 2018 10:58:05 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 86B8BE0309 for ; Mon, 5 Feb 2018 10:58:03 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 0992921E88 for ; Mon, 5 Feb 2018 10:58:02 +0000 (UTC) Date: Mon, 5 Feb 2018 10:58:02 +0000 (UTC) From: "Rohith Sharma K S (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-7835) [Atsv2] Race condition in NM while publishing events if second attempt launched on same node MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-7835?page=3Dcom.atlassian.= jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16352= 238#comment-16352238 ]=20 Rohith Sharma K S commented on YARN-7835: ----------------------------------------- bq. An alternative=C2=A0would be be to only clean up the collector when the= application finishes instead of when an AM container finishes It is doable and should be fine! One concern from very very rare scenario i= s this will make collector map to retain as long as application_stop event = triggers. Lets take example where 1st attempt is running in Node-1 and kill= ed. 2nd attempt started on different node, but Node-1 doesn't get applicati= on_stop event since application is still running which causes Node-1 to kee= p this map. Once application is finished, this will be removed but if it is= long running application, then this map will retain in two nodemanagers. I= t would be become a gradual leak in case of long running applications.=20 > [Atsv2] Race condition in NM while publishing events if second attempt la= unched on same node > -------------------------------------------------------------------------= ------------------- > > Key: YARN-7835 > URL: https://issues.apache.org/jira/browse/YARN-7835 > Project: Hadoop YARN > Issue Type: Bug > Reporter: Rohith Sharma K S > Assignee: Rohith Sharma K S > Priority: Critical > Attachments: YARN-7835.001.patch > > > It is observed race condition that if master container is killed for some= reason and launched on same node then NMTimelinePublisher doesn't add time= lineClient. But once completed container for 1st attempt has come then NMTi= melinePublisher removes the timelineClient.=20 > It causes all subsequent event publishing from different client fails to= publish with exception Application is not found. ! -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: yarn-issues-help@hadoop.apache.org