From yarn-issues-return-137248-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Mon Feb 5 10:46:06 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id F108E180647 for ; Mon, 5 Feb 2018 10:46:05 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id E0CC5160C4B; Mon, 5 Feb 2018 09:46:05 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 34B87160C46 for ; Mon, 5 Feb 2018 10:46:05 +0100 (CET) Received: (qmail 4692 invoked by uid 500); 5 Feb 2018 09:46:04 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 4681 invoked by uid 99); 5 Feb 2018 09:46:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 05 Feb 2018 09:46:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id BCA25C0160 for ; Mon, 5 Feb 2018 09:46:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id 6_ef-zsMqdSa for ; Mon, 5 Feb 2018 09:46:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 282E45F640 for ; Mon, 5 Feb 2018 09:46:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 2E867E01AD for ; Mon, 5 Feb 2018 09:46:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 60D8621E86 for ; Mon, 5 Feb 2018 09:46:00 +0000 (UTC) Date: Mon, 5 Feb 2018 09:46:00 +0000 (UTC) From: "Rohith Sharma K S (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-7346) Fix compilation errors against hbase2 beta release MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-7346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16352187#comment-16352187 ] Rohith Sharma K S commented on YARN-7346: ----------------------------------------- Update : As we discussed in last ATSv2 weekly call([~haibochen] [~vrushalic] [~varun_saxena]), decided to support conditional compilation so that ATSv2 should support hbase-1.2.6 which is already release along with Hadoop GA and HBase-2 as well. Currently all the hbase code are embedded in single jar. To support conditional compilation, straight forward approach is create another module which picks up if Hbase version is 2.0. But issue with this approach is duplicated code exist on both modules. After further discussion, we also thought of splitting into multiple jars such as *hadoop-yarn-server-timelineservice-hbase-common.jar* *hadoop-yarn-server-timelineservice-hbase-reader.jar* *hadoop-yarn-server-timelineservice-hbase-collector.jar* so that HBase co-processor code resides on collector jar which has co-processor modifications. Doing this brings out we can create any number of module for collectors if HBase changes any APIs. But cons from this approach is how does existing upgrade is handled? We also need to analyze running HBase with older timelineservice co processor jar and collector running with newer jars causes any issue provided we still maintain same class names. [~haibochen] [~vrushalic] feel free to add more point if I have missed any. > Fix compilation errors against hbase2 beta release > -------------------------------------------------- > > Key: YARN-7346 > URL: https://issues.apache.org/jira/browse/YARN-7346 > Project: Hadoop YARN > Issue Type: Sub-task > Reporter: Ted Yu > Assignee: Vrushali C > Priority: Major > Attachments: YARN-7346.00.patch, YARN-7346.01.patch, YARN-7346.prelim1.patch, YARN-7346.prelim2.patch, YARN-7581.prelim.patch > > > When compiling hadoop-yarn-server-timelineservice-hbase against 2.0.0-alpha3, I got the following errors: > https://pastebin.com/Ms4jYEVB > This issue is to fix the compilation errors. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: yarn-issues-help@hadoop.apache.org