From yarn-issues-return-138366-archive-asf-public=cust-asf.ponee.io@hadoop.apache.org Thu Feb 22 00:00:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 39BDB18067E for ; Thu, 22 Feb 2018 00:00:04 +0100 (CET) Received: (qmail 81127 invoked by uid 500); 21 Feb 2018 23:00:03 -0000 Mailing-List: contact yarn-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list yarn-issues@hadoop.apache.org Received: (qmail 81114 invoked by uid 99); 21 Feb 2018 23:00:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 21 Feb 2018 23:00:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 9EDDAC01A9 for ; Wed, 21 Feb 2018 23:00:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.311 X-Spam-Level: X-Spam-Status: No, score=-110.311 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id nKtpZ4nBI9JH for ; Wed, 21 Feb 2018 23:00:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 72BE25F5B3 for ; Wed, 21 Feb 2018 23:00:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id E63C0E0335 for ; Wed, 21 Feb 2018 23:00:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 4F53E21097 for ; Wed, 21 Feb 2018 23:00:00 +0000 (UTC) Date: Wed, 21 Feb 2018 23:00:00 +0000 (UTC) From: "Jim Brennan (JIRA)" To: yarn-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (YARN-5714) ContainerExecutor does not order environment map MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/YARN-5714?page=3Dcom.atlassian.= jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16372= 162#comment-16372162 ]=20 Jim Brennan commented on YARN-5714: ----------------------------------- As this has become a blocking issue for=C2=A0YARN-7677, I took the liberty = updating [~rcatherinot]'s patch. I made minimal changes to it, fixing some compilation issues that cropped u= p due to changes since then, fixed a bug in one of the tests where it was s= topping after a single iteration instead of running through all combination= s, and adding a few more test cases for getEnvDependencies. I tested this locally and it appears to work well.=C2=A0 =C2=A0I put up a n= ew patch to get the ball rolling on this one again. > ContainerExecutor does not order environment map > ------------------------------------------------ > > Key: YARN-5714 > URL: https://issues.apache.org/jira/browse/YARN-5714 > Project: Hadoop YARN > Issue Type: Bug > Components: nodemanager > Affects Versions: 2.4.1, 2.5.2, 2.7.3, 2.6.4, 3.0.0-alpha1 > Environment: all (linux and windows alike) > Reporter: Remi Catherinot > Assignee: Remi Catherinot > Priority: Trivial > Labels: oct16-medium > Attachments: YARN-5714.001.patch, YARN-5714.002.patch, YARN-5714.= 003.patch, YARN-5714.004.patch, YARN-5714.005.patch, YARN-5714.006.patch, Y= ARN-5714.007.patch > > Original Estimate: 120h > Remaining Estimate: 120h > > when dumping the launch container script, environment variables are dumpe= d based on the order internally used by the map implementation (hash based)= . It does not take into consideration that some env varibales may refer eac= h other, and so that some env variables must be declared before those refer= encing them. > In my case, i ended up having LD_LIBRARY_PATH which was depending on HADO= OP_COMMON_HOME being dumped before HADOOP_COMMON_HOME. Thus it had a wrong = value and so native libraries weren't loaded. jobs were running but not at = their best efficiency. This is just a use case falling into that bug, but i= 'm sure others may happen as well. > I already have a patch running in my production environment, i just estim= ate to 5 days for packaging the patch in the right fashion for JIRA + try m= y best to add tests. > Note : the patch is not OS aware with a default empty implementation. I w= ill only implement the unix version on a 1st release. I'm not used to windo= ws env variables syntax so it will take me more time/research for it. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org For additional commands, e-mail: yarn-issues-help@hadoop.apache.org