hadoop-yarn-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (YARN-7926) Copy and paste errors in log messages
Date Sun, 25 Feb 2018 20:25:00 GMT

    [ https://issues.apache.org/jira/browse/YARN-7926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16376228#comment-16376228
] 

ASF GitHub Bot commented on YARN-7926:
--------------------------------------

GitHub user lzh3636 opened a pull request:

    https://github.com/apache/hadoop/pull/345

    YARN-7926 fix a copy-and-paste error in log messages

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lzh3636/hadoop YARN-7926

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/hadoop/pull/345.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #345
    
----
commit 545b310c53d143bee4106f4e8e23fb4b07b74e28
Author: zhenhaoli <gino@...>
Date:   2018-02-25T20:21:47Z

    fix a copy-and-paste error in log messages

----


> Copy and paste errors in log messages
> -------------------------------------
>
>                 Key: YARN-7926
>                 URL: https://issues.apache.org/jira/browse/YARN-7926
>             Project: Hadoop YARN
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: Zhenhao Li
>            Priority: Minor
>              Labels: easyfix
>
> We found that there are some possible copy and paste errors in the log messages, and
we think it may cause some confusion when operators are reading the log messages.
>  
> The problem is found in the following two methods:
> _org.apache.hadoop.yarn.server.router.webapp.FederationInterceptorREST._*_createNewApplication()_* 
> and 
>  _org.apache.hadoop.yarn.server.router.clientrm.FederationClientInterceptor._*_getNewApplication()_*
> These are two very similar methods (possibly code clones) in different classes.
> The log messages in *both methods* are:
> _LOG.warn("Unable to_ *_create a new ApplicationId_* _in SubCluster " …);_
> _LOG.debug(“_*getNewApplication* try # + … );
> Since one method is getting new application and one method is creating new application,
we believe that the log messages are incorrectly copied and should be changed.
> Please let us know if there is anything that we can further provide you with fixing the
problem.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org


Mime
View raw message